Update to the latest Burn and pin dependencies #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of a lock file doesn't affect the versions that other crates will use, and it ensures that tests in CI are reproducible. Rust currently recommends not checking it in for libraries, but this appears to be about to change: rust-lang/cargo#8728
https://rust-lang.github.io/rust-clippy/master/index.html#/single_range_in_vec_init was triggering for lines like let rating = ratings.clone().slice([i..i + 1]).transpose(); I think the warning probably doesn't apply for this API.
dae
force-pushed
the
new-burn
branch
2 times, most recently
from
0f08929
to
7a78f93
Compare
Allowing it to float will lead to future clippy breakages, as clippy routinely adds extra checks in new updates.
Merged
|
Is it ready to merge? |
|
Yep, should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.