Skip to content

Commit

Permalink
Update to the latest Burn and pin dependencies (#33)
Browse files Browse the repository at this point in the history
* Add Cargo.lock

The presence of a lock file doesn't affect the versions that other crates
will use, and it ensures that tests in CI are reproducible. Rust currently
recommends not checking it in for libraries, but this appears to be about
to change:
rust-lang/cargo#8728

* Update to the latest Burn; pin to a specific commit

* Silence a clippy warning

https://rust-lang.github.io/rust-clippy/master/index.html#/single_range_in_vec_init
was triggering for lines like

  let rating = ratings.clone().slice([i..i + 1]).transpose();

I think the warning probably doesn't apply for this API.

* Fix a clippy warning

* Pin the Rust version

Allowing it to float will lead to future clippy breakages, as clippy
routinely adds extra checks in new updates.
  • Loading branch information
dae authored Aug 26, 2023
1 parent 87d11f0 commit b7f13e9
Show file tree
Hide file tree
Showing 6 changed files with 2,570 additions and 11 deletions.
6 changes: 1 addition & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
debug/
target/

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Cargo.lock

# These are backup files generated by rustfmt
**/*.rs.bk

Expand All @@ -16,4 +12,4 @@ Cargo.lock
.DS_Store

tmp/
*.anki21
*.anki21
Loading

0 comments on commit b7f13e9

Please sign in to comment.