Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding sealed keyword to classes #191

Merged
merged 4 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenFeature/Model/ClientMetadata.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ namespace OpenFeature.Model
/// <summary>
/// Represents the client metadata
/// </summary>
public class ClientMetadata : Metadata
public sealed class ClientMetadata : Metadata
{
/// <summary>
/// Version of the client
Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/Model/FlagEvaluationDetails.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace OpenFeature.Model
/// </summary>
/// <typeparam name="T">Flag value type</typeparam>
/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/types.md#evaluation-details"/>
public class FlagEvaluationDetails<T>
public sealed class FlagEvaluationDetails<T>
{
/// <summary>
/// Feature flag evaluated value
Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/Model/FlagEvaluationOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace OpenFeature.Model
/// The hook and hook hints are added to the list of hooks called during the evaluation process
/// </summary>
/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/types.md#evaluation-options">Flag Evaluation Options</seealso>
public class FlagEvaluationOptions
public sealed class FlagEvaluationOptions
{
/// <summary>
/// A immutable list of <see cref="Hook"/>
Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/Model/HookContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace OpenFeature.Model
/// </summary>
/// <typeparam name="T">Flag value type</typeparam>
/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/sections/04-hooks.md#41-hook-context"/>
public class HookContext<T>
public sealed class HookContext<T>
{
/// <summary>
/// Feature flag being evaluated
Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/Model/ResolutionDetails.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace OpenFeature.Model
/// </summary>
/// <typeparam name="T">Flag value type</typeparam>
/// <seealso href="https://github.com/open-feature/spec/blob/v0.5.2/specification/types.md#resolution-details"/>
public class ResolutionDetails<T>
public sealed class ResolutionDetails<T>
{
/// <summary>
/// Feature flag evaluated value
Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/NoOpProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace OpenFeature
{
internal class NoOpFeatureProvider : FeatureProvider
internal sealed class NoOpFeatureProvider : FeatureProvider
{
private readonly Metadata _metadata = new Metadata(NoOpProvider.NoOpProviderName);

Expand Down
2 changes: 1 addition & 1 deletion src/OpenFeature/ProviderRepository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace OpenFeature
/// <summary>
/// This class manages the collection of providers, both default and named, contained by the API.
/// </summary>
internal class ProviderRepository
internal sealed class ProviderRepository
{
private FeatureProvider _defaultProvider = new NoOpFeatureProvider();

Expand Down