Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding sealed keyword to classes #191

Merged
merged 4 commits into from
Jan 19, 2024
Merged

chore: Adding sealed keyword to classes #191

merged 4 commits into from
Jan 19, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Jan 18, 2024

Sealed keyword

  • This class seals some of the classes that are not being inherited.
  • If you think of a class that should be allowed inheritance, please block this PR so we can remove it

Notes

@askpt askpt requested a review from a team as a code owner January 18, 2024 17:26
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18a092a) 94.11% compared to head (041e2d5) 94.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          23       23           
  Lines         951      951           
  Branches      101      101           
=======================================
  Hits          895      895           
  Misses         32       32           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askpt askpt merged commit 1a14f6c into open-feature:main Jan 19, 2024
11 checks passed
@askpt askpt deleted the askpt/add-sealed-keyword branch January 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants