Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of "contracting process", replace with "contracting (or planning) process" #1513

Merged
merged 25 commits into from
Jun 10, 2022
Merged

Review use of "contracting process", replace with "contracting (or planning) process" #1513

merged 25 commits into from
Jun 10, 2022

Conversation

JachymHercher
Copy link
Contributor

@JachymHercher JachymHercher commented May 18, 2022 •
edited
Loading

Closes #1409

Closes #1517

@JachymHercher JachymHercher marked this pull request as draft May 18, 2022 07:43
@JachymHercher JachymHercher changed the title 1409 review use of contracting process Review use of "contracting process", replace with "contracting (or planning) process" May 18, 2022
@JachymHercher JachymHercher mentioned this pull request May 18, 2022
Closed
@JachymHercher JachymHercher added the Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) label May 18, 2022
@JachymHercher JachymHercher mentioned this pull request May 18, 2022
Closed
@JachymHercher JachymHercher marked this pull request as ready for review May 18, 2022 19:27
jpmckinney
jpmckinney reviewed May 19, 2022
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JachymHercher I've reviewed the schema section first. Once we resolve those, I think it'll be easier to review the rest.

schema/codelists/documentType.csv Outdated Show resolved Hide resolved
schema/codelists/documentType.csv Outdated Show resolved Hide resolved
schema/codelists/documentType.csv Outdated Show resolved Hide resolved
schema/codelists/partyRole.csv Outdated Show resolved Hide resolved
schema/codelists/partyRole.csv Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Show resolved Hide resolved
JachymHercher and others added 9 commits May 20, 2022 11:40
@JachymHercher
Clarify that environmental impact is of the purchase not the process
be8c64f
@JachymHercher @jpmckinney
Correct preposition, remove if applicable
e21ab98 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher @jpmckinney
Minor improvements to Budget.description
cc1d36d 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher @jpmckinney
Minor improvements to budget
744ec82 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher @jpmckinney
Minor improvements to Budget.uri
494df4d 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher @jpmckinney
Minor updates to Budget.id
4a7879f 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher @jpmckinney
Minor improvements to Budget.description II
d1f963c 
Co-authored-by: James McKinney <[email protected]>
@JachymHercher
Remove "future" in "future contracting process" for selection criteri…
93b050c 
…a and exclusion grounds
@JachymHercher
Replace "the future contracting process" with "a future contracting p…
37b9751 
…rocess"
@JachymHercher JachymHercher mentioned this pull request May 20, 2022
Closed
@JachymHercher JachymHercher mentioned this pull request May 20, 2022
Closed
jpmckinney
jpmckinney reviewed May 20, 2022
View reviewed changes
schema/codelists/documentType.csv Show resolved Hide resolved
schema/codelists/partyRole.csv Outdated Show resolved Hide resolved
jpmckinney
jpmckinney reviewed May 27, 2022
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to change this text on schema/reference (maybe using "future" - though I can't remember if there is an existing issue recently created):

The planning section can be used to describe the background to a contracting process. This can include details of the budget from which funds are drawn, or related projects for this contracting process. Background documents such as a needs assessment, feasibility study and project plan can also be included in this section.

We also need to update:

  • ocid and releases in record-package-schema.json
  • ocid in release-schema.json

docs/primer/releases_and_records.md Outdated Show resolved Hide resolved
@jpmckinney jpmckinney merged commit 2fdefea into 1.2-dev Jun 10, 2022
@jpmckinney jpmckinney deleted the 1409-review-use-of-contracting-process branch June 10, 2022 19:09
@jpmckinney jpmckinney mentioned this pull request Dec 2, 2022
Merged
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney left review comments

Assignees
No one assigned
Labels
Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.)
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
2 participants
@JachymHercher @jpmckinney