-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review usage of "contracting process" to account for planning process #1409
Comments
If I omit translations, the dereferenced schema, and the changelog, there are about 330 results, which is still a lot. That said, there are not too many open PRs that will conflict, so we don't need to wait. #1303 is already heaving conflicted, but the solution there, I think, is to move the work to a document or spreadsheet, and then only make the PR once the new definitions are agreed. The only way we'll resolve the conflicts is to overwrite the main branch's version, anyway. I agree that it is better to replace "contracting process" where appropriate, rather than to be ambiguous as to whether we might also mean "planning process". I prefer "contracting (or planning) process" as well. That said, I think "process" is fine once we've already used "contracting (or planning) process" in the same (or nearby) paragraphs; this is already done in some places. It's similar to using a pronoun. I think I only see "within the scope of" when discussing uniqueness, and "scope" is a common concept for uniqueness. Some identifiers are synthetic, so they are not properly "within" the real-world contracting process itself. |
Here is a draft PR. Before marking the PR ready for review, I'd like to get feedback on the highlights below. There are quite a few changes, so reviewing will likely be a mouthful, sorry for that. (If I had commits per issues below, the review would have been easier, but regrettably the issue classification emerged from doing the changes, not the other way around. There are separate commits only for points 7 and 8. Points 9 and 10 are not reflected in the PR yet.)
|
|
Cool. I've implemented your comment 1) in f19a741 (together with adding the word "tender" in "In some cases, a complex contracting activity cannot be represented as a single contracting process, because there are multiple tender stages.") and marked the PR as ready for review. Do we want to deal with 9) within the same PR or do a broader rewrite somewhere else? |
Thanks! Let's do 9 in another PR since we already have a PR ready for review. |
@JachymHercher in #866:
From #866 (comment):
The text was updated successfully, but these errors were encountered: