Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe handling of control plane promises & fix CI #389

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 18, 2023

Description

fixes #379

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

mdemoret-nv and others added 26 commits September 7, 2023 13:03
This reverts commit bd740aa.
@dagardner-nv dagardner-nv requested review from a team as code owners September 18, 2023 18:22
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #389 (041db9a) into branch-23.11 (9b47924) will decrease coverage by 22.35%.
Report is 7 commits behind head on branch-23.11.
The diff coverage is 31.62%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.11     #389       +/-   ##
=================================================
- Coverage         73.11%   50.77%   -22.35%     
=================================================
  Files               382      348       -34     
  Lines             13403    11171     -2232     
  Branches           1010      939       -71     
=================================================
- Hits               9800     5672     -4128     
- Misses             3603     5499     +1896     
Flag Coverage Δ
cpp 42.57% <30.83%> (-26.48%) ⬇️
py 41.92% <31.07%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cpp/mrc/src/internal/control_plane/client.cpp 0.00% <0.00%> (-70.10%) ⬇️
cpp/mrc/src/internal/control_plane/client.hpp 0.00% <0.00%> (-68.97%) ⬇️
...mrc/src/internal/control_plane/client/instance.cpp 0.00% <ø> (-37.21%) ⬇️
...rnal/control_plane/client/subscription_service.cpp 0.00% <ø> (ø)
cpp/mrc/src/internal/control_plane/server.cpp 0.00% <0.00%> (-41.27%) ⬇️
cpp/mrc/src/internal/control_plane/server.hpp 0.00% <ø> (-100.00%) ⬇️
cpp/mrc/src/internal/data_plane/client.cpp 0.00% <0.00%> (-14.52%) ⬇️
...c/src/internal/data_plane/data_plane_resources.cpp 0.00% <ø> (-72.50%) ⬇️
cpp/mrc/src/internal/data_plane/server.cpp 0.00% <ø> (-55.66%) ⬇️
.../mrc/src/internal/executor/executor_definition.cpp 53.06% <ø> (-25.79%) ⬇️
... and 18 more

... and 144 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5e40c...041db9a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Intermittent test failures for clang & gcc-coverage
2 participants