-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe handling of control plane promises & fix CI #391
Safe handling of control plane promises & fix CI #391
Conversation
…-cap-add=sys_nice [no ci]
…ntrol-plane-promises-dg
This reverts commit 5747320.
This reverts commit 29d9f00.
This reverts commit 5cf17e5.
This reverts commit 8524d89.
This reverts commit bd740aa.
This reverts commit c226ec1.
This reverts commit 1b20886.
… into mdd_control-plane-promises-dg-16
… they called executor.stop() insread of run
… they called executor.stop() insread of run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Mostly cleanup and fixing a few commented out tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Michael Demoret <[email protected]>
Co-authored-by: Michael Demoret <[email protected]>
Co-authored-by: Michael Demoret <[email protected]>
Co-authored-by: Michael Demoret <[email protected]>
Co-authored-by: Michael Demoret <[email protected]>
Co-authored-by: Michael Demoret <[email protected]>
…s, but CI checks against release builds
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #391 +/- ##
================================================
+ Coverage 73.11% 73.32% +0.20%
================================================
Files 382 385 +3
Lines 13403 13671 +268
Branches 1010 1026 +16
================================================
+ Hits 9800 10024 +224
- Misses 3603 3647 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/merge |
PR #391 updated the version of boost, but I forgot to update the version in the package's yaml. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Devin Robison (https://github.com/drobison00) - Michael Demoret (https://github.com/mdemoret-nv) URL: #404
Description
fixes #379
Checklist