Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Fix segfaults #266

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix segfaults #266

merged 2 commits into from
Aug 29, 2023

Conversation

smallhive
Copy link
Contributor

close #265

It just stopped to work and fails on container initialization.

Signed-off-by: Evgenii Baidakov <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #266 (b5c89f4) into master (465257d) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   34.29%   34.29%           
=======================================
  Files          10       10           
  Lines        1382     1382           
=======================================
  Hits          474      474           
  Misses        866      866           
  Partials       42       42           
Files Changed Coverage Δ
downloader/download.go 8.15% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallhive smallhive marked this pull request as ready for review August 29, 2023 06:47
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests: Fix panic, if object not found --- not tests

Code can be simplified a little, but OK as a fix in general.

downloader/download.go Outdated Show resolved Hide resolved
downloader/download.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit c4ad0d7 into master Aug 29, 2023
11 of 12 checks passed
@roman-khimov roman-khimov deleted the 265-segfaults branch August 29, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.27.2 segfaults with invalid memory address or nil pointer dereference
2 participants