Merge pull request #266 from nspcc-dev/265-segfaults

Fix segfaults

downloader/download.go

@@ -358,7 +358,7 @@ func (d *Downloader) byAttribute(c *fasthttp.RequestCtx, f func(request, *pool.P
 	if n == 0 {
 		err = res.Close()
 
-		if errors.Is(err, io.EOF) {
+		if err == nil || errors.Is(err, io.EOF) {
 			log.Error("object not found", zap.Error(err))
 			response.Error(c, "object not found", fasthttp.StatusNotFound)
 			return

integration_test.go

@@ -59,7 +59,6 @@ var (
 
 func TestIntegration(t *testing.T) {
 	versions := []dockerImage{
-		{image: "nspccdev/neofs-aio-testcontainer", version: "0.34.0"},
 		{image: "nspccdev/neofs-aio", version: "0.37.0"}, // 0.37.0 is the latest
 	}
 
@@ -84,6 +83,7 @@ func TestIntegration(t *testing.T) {
 		t.Run("put with duplicate keys "+image, func(t *testing.T) { putWithDuplicateKeys(t, CID) })
 		t.Run("simple get "+image, func(t *testing.T) { simpleGet(ctx, t, clientPool, ownerID, CID, signer) })
 		t.Run("get by attribute "+image, func(t *testing.T) { getByAttr(ctx, t, clientPool, ownerID, CID, signer) })
+		t.Run("get by attribute, not found "+image, func(t *testing.T) { getByAttrNotFound(t) })
 		t.Run("get zip "+image, func(t *testing.T) { getZip(ctx, t, clientPool, ownerID, CID, signer) })
 
 		cancel()
@@ -274,6 +274,15 @@ func getByAttr(ctx context.Context, t *testing.T, clientPool *pool.Pool, ownerID
 	checkGetByAttrResponse(t, resp, content, expectedAttr)
 }
 
+func getByAttrNotFound(t *testing.T) {
+	keyAttr, valAttr := "some-attr-no", "some-get-by-attr-value-no"
+
+	resp, err := http.Get(testHost + "/get_by_attribute/" + testContainerName + "/" + keyAttr + "/" + valAttr)
+
+	require.Equal(t, http.StatusNotFound, resp.StatusCode)
+	require.NoError(t, err)
+}
+
 func getZip(ctx context.Context, t *testing.T, clientPool *pool.Pool, ownerID user.ID, CID cid.ID, signer user.Signer) {
 	names := []string{"zipfolder/dir/name1.txt", "zipfolder/name2.txt"}
 	contents := []string{"content of file1", "content of file2"}