Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RQC generator #101

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix RQC generator #101

wants to merge 12 commits into from

Conversation

s-mandra
Copy link
Member

It should be possible to directly use the output from the RQC generator in qFlex.

@alexandrupaler
Copy link
Contributor

i will integrate the rqc generator with the python code from the PR. The code there includes grid generation scripts. Allow me two days to have this solved and committed.

@s-mandra
Copy link
Member Author

i will integrate the rqc generator with the python code from the PR. The code there includes grid generation scripts. Allow me two days to have this solved and committed.

Thanks. For now, I've just updated the patterns to follow the corresponding grids in config/grid. The idea is to directly use the circuits from your rqc generator with qFlex.

@s-mandra s-mandra added the duplicate This issue or pull request already exists label Oct 17, 2019
@s-mandra s-mandra changed the title Fix RQC generator Fix RQC generator (depends on #121) Oct 20, 2019
@s-mandra
Copy link
Member Author

This PR just modifies patterns to be compatible with the corresponding grids.

@s-mandra s-mandra marked this pull request as ready for review October 20, 2019 03:21
@s-mandra
Copy link
Member Author

Resolve #98.

@s-mandra s-mandra removed the duplicate This issue or pull request already exists label Oct 20, 2019
@95-martin-orion
Copy link
Contributor

Error running generator_test.py:

$ make run-tests
generator_test.py:22: in <module>
    Rochester = GetDevice('../../config/patterns/ibm_rochester.txt')
generator_test.py:18: in GetDevice
    return generator.Device(pattern)
../../python/circuits/generator.py:42: in __init__
    assert list(qubits) == list(range(self.n_qubits))
E   AssertionError

If I run manually from the qflex directory, I get a different error:

$ python3 -m pytest tests/python/generator_test.py 
tests/python/generator_test.py:21: in <module>
    TestDevice = GetDevice('../../config/patterns/test.txt')
tests/python/generator_test.py:16: in GetDevice
    with open(pattern_filename, 'r') as f:
E   FileNotFoundError: [Errno 2] No such file or directory: '../../config/patterns/test.txt'

@s-mandra
Copy link
Member Author

Error running generator_test.py:

$ make run-tests
generator_test.py:22: in <module>
    Rochester = GetDevice('../../config/patterns/ibm_rochester.txt')
generator_test.py:18: in GetDevice
    return generator.Device(pattern)
../../python/circuits/generator.py:42: in __init__
    assert list(qubits) == list(range(self.n_qubits))
E   AssertionError

If I run manually from the qflex directory, I get a different error:

$ python3 -m pytest tests/python/generator_test.py 
tests/python/generator_test.py:21: in <module>
    TestDevice = GetDevice('../../config/patterns/test.txt')
tests/python/generator_test.py:16: in GetDevice
    with open(pattern_filename, 'r') as f:
E   FileNotFoundError: [Errno 2] No such file or directory: '../../config/patterns/test.txt'

I solved this problem but there are other issue regarding the indexing. It should be an easy fix, but for now I'll close this PR (still too buggy).

@s-mandra s-mandra closed this Oct 20, 2019
@s-mandra s-mandra deleted the fix-rqc-generator branch October 24, 2019 18:12
@s-mandra s-mandra restored the fix-rqc-generator branch October 24, 2019 19:06
@s-mandra s-mandra reopened this Oct 24, 2019
@s-mandra s-mandra changed the title Fix RQC generator (depends on #121) Fix RQC generator Oct 24, 2019
@s-mandra s-mandra added this to the Post-release fixes milestone Oct 24, 2019
@95-martin-orion
Copy link
Contributor

Sorry I've left this unanswered for so long - is the current state up for review (aside from the Travis formatting issues)?

@95-martin-orion 95-martin-orion removed their request for review November 6, 2019 17:41
@s-mandra s-mandra added the wontfix This will not be worked on label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants