Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making RQC generator output compatible with qFlex input. #98

Open
s-mandra opened this issue Oct 15, 2019 · 7 comments
Open

Making RQC generator output compatible with qFlex input. #98

s-mandra opened this issue Oct 15, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@s-mandra
Copy link
Member

No description provided.

@s-mandra s-mandra added the must do Must do label Oct 15, 2019
@s-mandra s-mandra added this to the qFlex initial release milestone Oct 15, 2019
@s-mandra s-mandra self-assigned this Oct 15, 2019
@s-mandra
Copy link
Member Author

See #101.

@95-martin-orion 95-martin-orion removed this from the qFlex initial release milestone Oct 23, 2019
@s-mandra s-mandra added the wontfix This will not be worked on label Oct 24, 2019
@95-martin-orion 95-martin-orion added enhancement New feature or request and removed must do Must do wontfix This will not be worked on labels Oct 24, 2019
@95-martin-orion 95-martin-orion added this to the Post-release fixes milestone Oct 24, 2019
@95-martin-orion 95-martin-orion assigned viathor and unassigned s-mandra Oct 24, 2019
@alexandrupaler
Copy link
Contributor

Is this still an issue?

@s-mandra
Copy link
Member Author

s-mandra commented Mar 6, 2020

It is still an issue. I have few workaround that could be potentially implemented, but it would be better if the rqc generator would output the circuit using the same indexes for qubits that qflex actually uses.

@viathor
Copy link
Collaborator

viathor commented Mar 6, 2020

What is the current qubit indexing scheme in qflex? I recall there had been plans to change it...

@s-mandra
Copy link
Member Author

s-mandra commented Mar 6, 2020

qflex uses the provided grid to number the qubits. For instance, for the IBM rochester, the grid can be found in config/grid and numbers are assigned to qubits regardless if they are active or not in the grid (starting from the top left to the bottom right). The RQC assigns instead numbers only for the active qubits. To this end, the RQC could accept a grid as an input and then reindex everything accordingly to the grid.

@viathor
Copy link
Collaborator

viathor commented Mar 7, 2020

I have a recollection of us deciding (or at least considering) to use contiguous indices for consistency with qsim. Do we still intend to do that?

If so, then instead of changing the RQC generator, I can change qflex to use contiguous indices in the input files.

@s-mandra
Copy link
Member Author

s-mandra commented Mar 7, 2020

I have a recollection of us deciding (or at least considering) to use contiguous indices for consistency with qsim. Do we still intend to do that?

If so, then instead of changing the RQC generator, I can change qflex to use contiguous indices in the input files.

At the moment, qflex is compatible with cirq (which doesn’t use contiguous indexes) so I would keep the compatibility with cirq rather than with qsim. In my opinion, I would prefer to add a flag to the rqc to either output the circuit using contiguous indexes or following a specific grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants