-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: add Coredumpd #64
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,205 @@ | ||
from __future__ import annotations | ||
|
||
import re | ||
from typing import Literal | ||
|
||
import pytest | ||
|
||
from .. import MultihostArtifactsType, MultihostHost, MultihostUtility | ||
from ..ssh import SSHLog | ||
from .fs import LinuxFileSystem | ||
|
||
__all__ = ["Coredumpd"] | ||
|
||
|
||
class Coredumpd(MultihostUtility[MultihostHost]): | ||
""" | ||
Coredumpd utilities. | ||
|
||
Collects generated core files from /var/lib/systemd/coredump and if there | ||
are any, optionally fail the test. | ||
|
||
.. note:: | ||
|
||
In order for this functionality to work correctly, systemd-coredumpd | ||
must be configured to store the core files in a directory (default), not | ||
in a journal. | ||
|
||
See ``man coredump.conf`` and its ``Storage`` option for more | ||
information. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
host: MultihostHost, | ||
fs: LinuxFileSystem, | ||
*, | ||
mode: Literal["fail", "warn", "ignore"] = "ignore", | ||
filter: str | None = None, | ||
path: str = "/var/lib/systemd/coredump", | ||
) -> None: | ||
""" | ||
``mode`` values: | ||
|
||
* ``ignore``: all failures are ignored | ||
* ``warn``: test result category is set to "COREDUMPS" and the test is | ||
marked as such in a test summary, however test outcome and pytest exit | ||
code is kept intact | ||
* ``fail``: test result category is set to "COREDUMPS" and the test is | ||
marked as such in a test summary, if a test outcome is ``passed`` it | ||
is set to ``failed`` and pytest will return non-zero exit code | ||
|
||
:param host: Multihost host. | ||
:type host: MultihostHost | ||
:param mode: Action taken when a core file is found. | ||
:type mode: Literal["fail", "warn", "ignore"] | ||
:param filter: Regular expression used to filter the core file names, | ||
defaults to None | ||
:type filter: str | None, optional | ||
:param path: Path to the directory where core files are stored, defaults | ||
to ``/var/lib/systemd/coredump`` | ||
:type path: str | ||
""" | ||
super().__init__(host) | ||
|
||
self.fs: LinuxFileSystem = fs | ||
|
||
self.mode: Literal["fail", "warn", "ignore"] = mode | ||
"""Action taken when a core file is found.""" | ||
|
||
self.filter: str | None = None | ||
"""Regular expression to filter core file names.""" | ||
|
||
self.path: str = path | ||
"""Path to the directory where core files are stored.""" | ||
|
||
self._corefiles: list[str] | None = None | ||
|
||
def setup(self) -> None: | ||
""" | ||
Backup and remove /var/lib/systemd/coredump. | ||
|
||
This directory will be automatically re-created by systemd-coredumpd if | ||
needed. | ||
""" | ||
super().setup() | ||
|
||
self.fs.rm("/var/lib/systemd/coredump") | ||
|
||
def list_core_files(self) -> list[str]: | ||
""" | ||
List available core files. | ||
|
||
:return: List of core file names. | ||
:rtype: list[str] | ||
""" | ||
# List the folder, exit with 0 if it does not exist (no core files were produced) | ||
result = self.host.ssh.run(f"[ -d '{self.path}' ] && ls -N -1 '{self.path}' || :", log_level=SSHLog.Error) | ||
|
||
return result.stdout_lines | ||
|
||
def parse_core_file_name(self, name: str) -> tuple[str, str]: | ||
""" | ||
Parse core file name and get the PID and timestamp information. | ||
|
||
Expected format is core.{binary}.{bootid}.{pid}.{timestamp}[.zst] | ||
|
||
:param name: Core file name. | ||
:type name: str | ||
:raises ValueError: If the core file name has unexpected format. | ||
:return: Tuple of ``(PID, timestamp)``. | ||
:rtype: tuple[str, str] | None | ||
""" | ||
parts = name.split(".") | ||
if not parts or len(parts) < 3: | ||
raise ValueError(f"Invalid coredump name: {name}") | ||
|
||
# If the file is compressed, remove the extension | ||
if not parts[-1].isnumeric(): | ||
parts.pop() | ||
|
||
pid = parts[-2] | ||
timestamp = parts[-1] | ||
|
||
return (pid, timestamp) | ||
|
||
def get_artifacts_list(self, host: MultihostHost, type: MultihostArtifactsType) -> set[str]: | ||
""" | ||
Dump backtrace and other information from generated core files for easy access. | ||
|
||
:param host: Host where the artifacts are being collected. | ||
:type host: MultihostHost | ||
:param type: Type of artifacts that are being collected. | ||
:type type: MultihostArtifactsType | ||
:return: List of artifacts to collect. | ||
:rtype: set[str] | ||
""" | ||
if self._corefiles is None: | ||
self._corefiles = self.list_core_files() | ||
|
||
if not self._corefiles: | ||
return set() | ||
|
||
# Parse PID and timestamp that we can use to get information for journal | ||
for name in self._corefiles: | ||
try: | ||
pid, timestamp = self.parse_core_file_name(name) | ||
except ValueError: | ||
self.logger.warn(f"Invalid core file name: {name}") | ||
continue | ||
|
||
# Dump the information | ||
self.host.ssh.run( | ||
rf""" | ||
journalctl --output=verbose \ | ||
'COREDUMP_PID={pid}' \ | ||
'COREDUMP_TIMESTAMP={timestamp}' \ | ||
> '{self.path}/{name}.backtrace' | ||
""", | ||
log_level=SSHLog.Error, | ||
) | ||
|
||
return {self.path} | ||
|
||
def pytest_report_teststatus( | ||
self, report: pytest.CollectReport | pytest.TestReport, config: pytest.Config | ||
) -> tuple[str, str, str | tuple[str, dict[str, bool]]] | None: | ||
""" | ||
Report core file found error if found and matches requested filter. | ||
|
||
:param report: Pytest report | ||
:type report: pytest.CollectReport | pytest.TestReport | ||
:param config: Pytest config | ||
:type config: pytest.Config | ||
:return: Pytest test status | ||
:rtype: tuple[str, str, str | tuple[str, dict[str, bool]]] | None | ||
""" | ||
if report.when != "call": | ||
return None | ||
|
||
if self.mode == "ignore" or report.outcome == "skipped": | ||
return None | ||
|
||
self.logger.info("Checking for core files") | ||
|
||
if self._corefiles is None: | ||
self._corefiles = self.list_core_files() | ||
|
||
if not self._corefiles: | ||
return None | ||
|
||
# Ignore if no core files matches the filter | ||
if self.filter: | ||
match = re.search(self.filter, "\n".join(self._corefiles)) | ||
if match is None: | ||
return None | ||
|
||
original_outcome = report.outcome | ||
|
||
# Fail the test if fail mode is selected | ||
if report.outcome == "passed" and self.mode == "fail": | ||
report.outcome = "failed" | ||
|
||
# Count this test into "COREDUMPS" category in the final summary, | ||
# mark it with "C"/"COREDUMP" in short/verbose listing. | ||
return ("COREDUMPS", "C", f"{original_outcome.upper()}/COREDUMP") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason to have
if report.outcome == "passed"
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the test passed, we want to switch it to fail, otherwise don't touch the outcome. In theory, the outcome here may only be "passed" or "failed" so this check is redundant. But I added it for verbosity and future safety.