utils: add Coredumpd #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collects generated core files from /var/lib/systemd/coredump and if there are any, optionally fail the test.
|
You will need VM to test this as coredumps produced from with in containers are still stored on the host. There is ongoing work to enable to store the coredump directly in the container, so we'll likely get that in the future as well. |
| original_outcome = report.outcome | ||
|
|
||
| # Fail the test if fail mode is selected | ||
| if report.outcome == "passed" and self.mode == "fail": |
There was a problem hiding this comment.
what is the reason to have if report.outcome == "passed" here?
There was a problem hiding this comment.
If the test passed, we want to switch it to fail, otherwise don't touch the outcome. In theory, the outcome here may only be "passed" or "failed" so this check is redundant. But I added it for verbosity and future safety.
justin-stephenson
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects generated core files from /var/lib/systemd/coredump and if there
are any, optionally fail the test.