Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft sample entity #1

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/02-common-principles.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ misunderstanding we clarify them here.
context, a session may also indicate a group of related scans,
taken in one or more visits.

1. **Sample** - a sample pertaining to a subject such as tissue, primary cell
or cell-free sample.
The `sample-<label>` key/value is used to distinguish between different
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `sample-<label>` key/value is used to distinguish between different
The `sample-<label>` key/value pair is used to distinguish between different

samples from a same subject.
mariehbourget marked this conversation as resolved.
Show resolved Hide resolved
The label MUST be unique per subject and is RECOMMENDED to be unique
throughout the dataset.

1. **Data acquisition** - a continuous uninterrupted block of time during which
a brain scanning instrument was acquiring data according to particular
scanning sequence/protocol.
Expand Down
11 changes: 11 additions & 0 deletions src/schema/entities.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ session:
often in the case of some intervention between sessions
(for example, training).
format: label
sample:
name: Sample
entity: sample
description: |
A sample pertaining to a subject such as tissue, primary cell
or cell-free sample.
The `sample-<label>` key/value is used to distinguish between different
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `sample-<label>` key/value is used to distinguish between different
The `sample-<label>` key/value pair is used to distinguish between different

samples from a same subject.
mariehbourget marked this conversation as resolved.
Show resolved Hide resolved
The label MUST be unique per subject and is RECOMMENDED to be unique
throughout the dataset.
format: label
task:
name: Task
entity: task
Expand Down