Draft sample entity #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jcohenadad, I updated the sample description following our meeting last week. Let me know if that it ok with you and I'll open a PR on the main bids repo. Thanks! |
jcohenadad
reviewed
May 31, 2021
jcohenadad
reviewed
May 31, 2021
Co-authored-by: Julien Cohen-Adad <[email protected]>
Co-authored-by: Julien Cohen-Adad <[email protected]>
mariehbourget
commented
May 31, 2021
There was a problem hiding this comment.
@jcohenadad, just so you know, I'm adding "pair" after key/value in both definitions.
| @@ -32,6 +32,13 @@ misunderstanding we clarify them here. | |||
| context, a session may also indicate a group of related scans, | |||
| taken in one or more visits. | |||
|
|
|||
| 1. **Sample** - a sample pertaining to a subject such as tissue, primary cell | |||
| or cell-free sample. | |||
| The `sample-<label>` key/value is used to distinguish between different | |||
There was a problem hiding this comment.
Suggested change
| The `sample-<label>` key/value is used to distinguish between different | |
| The `sample-<label>` key/value pair is used to distinguish between different |
| description: | | ||
| A sample pertaining to a subject such as tissue, primary cell | ||
| or cell-free sample. | ||
| The `sample-<label>` key/value is used to distinguish between different |
There was a problem hiding this comment.
Suggested change
| The `sample-<label>` key/value is used to distinguish between different | |
| The `sample-<label>` key/value pair is used to distinguish between different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- PLEASE READ AND DELETE THE TEXT BELOW BEFORE OPENING THE PULL REQUEST ---
See the CONTRIBUTING guide. Specifically:
appear in the changelog.
To add your name, please edit our Contributors wiki and add your name with the type of contribution.
For assistance, please contact @franklin-feingold or @sappelhoff.
[ENH]- enhancement of the specification that adds a new feature orsupport for a new data type
[FIX]- fix of a typo or language clarification[INFRA]- changes to the infrastructure automating the specificationrelease (for example building HTML docs etc.)
[MISC]- everything else including changes to the file listingcontributors
are not ready to be merged (a.k.a. Work in Progress PR) please
use a draft PR.
To see the checks and preview, scroll down and click on the
show all checkslink.From the list, select the
Detailslink of theci/circleci: build_docs artifactcheck to see the preview of the BIDS specification.--- PLEASE READ AND DELETE THE TEXT ABOVE BEFORE OPENING THE PULL REQUEST ---