-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Display document status of other dimensions in dimension dropdown #3680
base: 8.4
Are you sure you want to change the base?
FEATURE: Display document status of other dimensions in dimension dropdown #3680
Conversation
This is a successor PR of #3597 |
Hello, and thanks to @pKallert for highlighting that fantastic feature. I've reviewed the code and experimented with it, and it functions as you outlined. However, I'm not particularly fond of the strikeout method for disallowed dimensions. With the introduction of the new grouping feature in UI version 8.4, I thought about utilizing groups for this purpose. This approach could potentially enhance the user experience, as users would better comprehend the implications. We could incorporate a helpful text within the groups to explain the meaning of terms like "untranslated" or "disallowed." Additionally, it might be beneficial to consider hiding disallowed dimensions, as they occupy space without serving any practical purpose. What do you and the others think about that? |
Addendum: Linking to other dimensions in a new tab doesn't work for me in Firefox, Chrome and Safari |
f642c52
to
7da44f2
Compare
7da44f2
to
76c0299
Compare
That's funny, I also had this topic yesterday on my desk to continue with that.
I am also half the way of the implementation. What do you think about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one. ❤️ This will make my life much easier. 😄
Looks good by reading
@pKallert nice visualization. As addition and because I'm not sure if I'm missing it: are we explaining the color codes to the user, e.g. via using the title attribute? |
And pipeline is complaining and needs to get fixed before merge! |
Not right now, but I will get on that :) |
The title says draft, but we are ready for review correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, looks great, left some suggestions.
packages/neos-ui/src/Containers/PrimaryToolbar/DimensionSwitcher/index.js
Outdated
Show resolved
Hide resolved
packages/react-ui-components/src/SelectBox_Option_SingleLine/style.module.css
Outdated
Show resolved
Hide resolved
packages/react-ui-components/src/SelectBox_Option_SingleLine/style.module.css
Outdated
Show resolved
Hide resolved
packages/neos-ui/src/Containers/PrimaryToolbar/DimensionSwitcher/DimensionSelectorOption.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Helzle <[email protected]>
…//github.com/pKallert/neos-ui into feature/AddInactiveContentDimensionsDropdown
The striped background is more different to the 'edited' marking we have on other places in the CMS. Therefore, it might highlight the difference a bit better. |
@ahaeslich is right here. You could think, that there are unpublished nodes in this dimension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the feature again.
It looks great but there is one problem, the state is not properly updated after creating the non-existing variant.
- So in the demo I'm in English
- then German has the stripes
- then I create the German variant via the modal
- dropdown shows all variants normally
- I go back to English
- German is still shown as non-existing (but it won't show the create variant dialog when I click again)
Solves partially #3413
What I did
In the single-dimensions dropdown, the Languages with existing documents are now a linked and can be opened in a new tab.
The dropdown now shows which dimensions the current already document exists in. "Not allowed" dimensions have a new styling
How I did it
For the dimensions menu there are two scenarios. This here describes the current implementation, but everything is still up for discussion
Single dimension
"Shine through" for en_UK and en_US
=> English(US) and English(UK) can be opened in new tab
For "normal" languages: only one dimensions highlighted
Multiple dimensions
(Currently) no shine through for dimensions.
No linking of dimensions, this is what the apply button is for, I think?
Disallowed dimensions are marked with strike-through (for now)
Available dimensions are shown top-down.
For example, if in the first dropdown "Deutsch" is chosen as the language, in the second dropdown only the variants with language deutsch and country * will be chosen.
ToDos
To be discussed