DRAFT FEATURE: add information to dimensions menu #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link to make it possible to open it in a new browser tab
MiauzGenau
commented
Aug 16, 2023
|
|
||
| return mapValues(dimensionConfiguration.presets, | ||
| (presetConfiguration, presetName) => { | ||
| // if we do not know which dimensions exist, show all as existing | ||
| let existing = existingDimensions.length === 1 && existingDimensions[0] === undefined; |
There was a problem hiding this comment.
Issue: Sometimes we do not get the existing dimensions (?switching between dimensions with overlapping defined values)
What should be displayed in this case.? (does not feel right, to mix showing and not showing the information)
(currently if we do not get the existing dimensions, all get shown as existing (white text))
|
Does this feature replace the plugin https://github.com/Flowpack/Flowpack.NodeVariantSelector ? |
|
@pKallert is working on that topic to bring it to Version 8.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3413
What I did
Show in the dimension menu, if a dimension already exists.
Add links to existing dimensions, to be able to open them in new browser tabs.
How I did it
getNodeByContextPath gives us a Node with otherNodeVariants attached.
With this information we can find out, which content dimensions already exist and display it in the menu.
For the URL building, I use the current contextPath and append the respective dimensions.
How to verify it
Look at dimension switcher on pages, where not all dimensions exist.
How it looks
Before:
(grey = disallowed)
After:
(grey = does not exist, strike-through = disallowed)