Allow for audit exception for $JS.EVENT.> and $SYS.ACCOUNT.> which may already exist.
#5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ack flag set. This exception is for pre-existing audit streams that would not recover on a server upgrade. Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
We will allow if no-ack and R1. Signed-off-by: Derek Collison <[email protected]>
derekcollison
force-pushed
the
audit-exception
branch
from
471284c
to
25a7d2c
Compare
|
Added in protection for ">" as well. Fixed tests, so should be green now. |
Signed-off-by: Derek Collison <[email protected]>
derekcollison
changed the title
$JS.EVENT.> which may already exist.$JS.EVENT.> and $SYS.ACCOUNT.> which may already exist.
neilalexander
pushed a commit
that referenced
this pull request
Jun 18, 2024
…h may already exist. (#5556) Signed-off-by: Derek Collison <[email protected]> --------- Signed-off-by: Derek Collison <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Jun 18, 2024
Includes the following: * #5552 * #5557 * #5556 * #5558 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison [email protected]