Added protection for trying to capture all subjects ">" in a stream.

We will allow if no-ack and R1.

Signed-off-by: Derek Collison <[email protected]>

server/jetstream_test.go

@@ -23648,7 +23648,13 @@ func TestJetStreamAuditStreams(t *testing.T) {
  })
  require_Error(t, err, NewJSStreamInvalidConfigError(sysOverlap))
 
- // These should be ok if no pub ack.
+ _, err = js.AddStream(&nats.StreamConfig{
+ Name: "TEST",
+ Subjects: []string{">"},
+ })
+ require_Error(t, err, NewJSStreamInvalidConfigError(errors.New("capturing all subjects requires no-ack to be true")))
+
+ // These should all be ok if no pub ack.
  _, err = js.AddStream(&nats.StreamConfig{
  Name: "TEST1",
  Subjects: []string{"$JS.>"},
@@ -23683,4 +23689,34 @@ func TestJetStreamAuditStreams(t *testing.T) {
  NoAck: true,
  })
  require_NoError(t, err)
+
+ // Specific test for capturing everything which will require both no-ack and replicas of 1.
+ c := createJetStreamClusterExplicit(t, "R3S", 3)
+ defer c.shutdown()
+
+ nc, js = jsClientConnect(t, c.randomServer())
+ defer nc.Close()
+
+ _, err = js.AddStream(&nats.StreamConfig{
+ Name: "TEST",
+ Subjects: []string{">"},
+ })
+ require_Error(t, err, NewJSStreamInvalidConfigError(errors.New("capturing all subjects requires no-ack to be true")))
+
+ _, err = js.AddStream(&nats.StreamConfig{
+ Name: "TEST",
+ Subjects: []string{">"},
+ Replicas: 3,
+ NoAck: true,
+ })
+ require_Error(t, err, NewJSStreamInvalidConfigError(errors.New("capturing all subjects requires replicas of 1")))
+
+ // Ths should work ok.
+ _, err = js.AddStream(&nats.StreamConfig{
+ Name: "TEST",
+ Subjects: []string{">"},
+ Replicas: 1,
+ NoAck: true,
+ })
+ require_NoError(t, err)
 }

server/stream.go

@@ -1502,6 +1502,16 @@ func (s *Server) checkStreamCfg(config *StreamConfig, acc *Account) (StreamConfi
  if _, ok := dset[subj]; ok {
  return StreamConfig{}, NewJSStreamInvalidConfigError(fmt.Errorf("duplicate subjects detected"))
  }
+ // Check for trying to capture everything.
+ if subj == fwcs {
+ if !cfg.NoAck {
+ return StreamConfig{}, NewJSStreamInvalidConfigError(fmt.Errorf("capturing all subjects requires no-ack to be true"))
+ }
+ // Capturing everything also will require R1.
+ if cfg.Replicas != 1 {
+ return StreamConfig{}, NewJSStreamInvalidConfigError(fmt.Errorf("capturing all subjects requires replicas of 1"))
+ }
+ }
  // Also check to make sure we do not overlap with our $JS API subjects.
  if !cfg.NoAck && (subjectIsSubsetMatch(subj, "$JS.>") || subjectIsSubsetMatch(subj, "$JSC.>")) {
  // We allow an exception for $JS.EVENT.> since these could have been created in the past.