SVOM Mission Page

.github/workflows/pull_request.yml

@@ -11,6 +11,8 @@ on:
 jobs:
   node:
     uses: nasa-gcn/.github/.github/workflows/node.yml@main
+    secrets:
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
   playwright:
     timeout-minutes: 60
     runs-on: ubuntu-latest

.npmrc

@@ -0,0 +1 @@
+prefer-dedupe=true

__tests__/table-streams/synonyms.ts

@@ -0,0 +1,185 @@
+import { tables } from '@architect/functions'
+import { search } from '@nasa-gcn/architect-functions-search'
+import type { DynamoDBRecord } from 'aws-lambda'
+
+import type { Synonym } from '~/routes/synonyms/synonyms.lib'
+import { handler } from '~/table-streams/synonyms/index'
+
+const synonymId = 'abcde-abcde-abcde-abcde-abcde'
+const eventId = 'GRB 123'
+const existingEventId = 'GRB 99999999'
+
+const putData = {
+  index: 'synonym-groups',
+  id: synonymId,
+  body: {
+    synonymId,
+    eventIds: [] as string[],
+  },
+}
+
+jest.mock('@nasa-gcn/architect-functions-search', () => ({
+  search: jest.fn(),
+}))
+
+jest.mock('@architect/functions', () => ({
+  tables: jest.fn(),
+}))
+
+const mockIndex = jest.fn()
+const mockDelete = jest.fn()
+const mockQuery = jest.fn()
+
+const mockStreamEvent = {
+  Records: [
+    {
+      eventID: '1',
+      eventName: 'INSERT',
+      eventVersion: '1.0',
+      eventSource: 'aws:dynamodb',
+      awsRegion: 'us-west-2',
+      dynamodb: {
+        Keys: {
+          synonymId: {
+            S: synonymId,
+          },
+          eventId: {
+            S: eventId,
+          },
+        },
+        NewImage: {
+          synonymId: {
+            S: synonymId,
+          },
+          eventId: {
+            S: eventId,
+          },
+        },
+        SequenceNumber: '111',
+        SizeBytes: 26,
+        StreamViewType: 'NEW_IMAGE',
+      },
+      eventSourceARN:
+        'arn:aws:dynamodb:us-west-2:123456789012:table/synonym-groups/stream/2020-01-01T00:00:00.000',
+    } as DynamoDBRecord,
+  ],
+}
+
+afterEach(() => {
+  jest.clearAllMocks()
+})
+
+describe('testing put synonymGroup table-stream', () => {
+  test('insert new synonym group', async () => {
+    const mockItems = [{ synonymId, eventId }]
+    const mockClient = {
+      synonyms: {
+        query: mockQuery,
+      },
+    }
+    mockQuery.mockResolvedValue({ Items: mockItems })
+    ;(tables as unknown as jest.Mock).mockResolvedValue(mockClient)
+    putData.body.eventIds = [eventId]
+    ;(search as unknown as jest.Mock).mockReturnValue({
+      index: mockIndex,
+      delete: mockDelete,
+    })
+
+    await handler(mockStreamEvent)
+
+    expect(mockIndex).toHaveBeenCalledWith(putData)
+  })
+
+  test('insert into existing synonym group', async () => {
+    const mockItems = [
+      { synonymId, eventId: existingEventId },
+      { synonymId, eventId },
+    ]
+    const mockClient = {
+      synonyms: {
+        query: mockQuery,
+      },
+    }
+    mockQuery.mockResolvedValue({ Items: mockItems })
+    ;(tables as unknown as jest.Mock).mockResolvedValue(mockClient)
+    putData.body.eventIds = [existingEventId, eventId]
+    ;(search as unknown as jest.Mock).mockReturnValue({
+      index: mockIndex,
+      delete: mockDelete,
+    })
+
+    await handler(mockStreamEvent)
+
+    expect(mockIndex).toHaveBeenCalledWith(putData)
+  })
+
+  test('insert only once', async () => {
+    const mockItems = [
+      { synonymId, eventId: existingEventId },
+      { synonymId, eventId },
+    ]
+    const mockClient = {
+      synonyms: {
+        query: mockQuery,
+      },
+    }
+    mockQuery.mockResolvedValue({ Items: mockItems })
+    ;(tables as unknown as jest.Mock).mockResolvedValue(mockClient)
+    putData.body.eventIds = [existingEventId, eventId]
+    ;(search as unknown as jest.Mock).mockReturnValue({
+      index: mockIndex,
+      delete: mockDelete,
+    })
+
+    await handler(mockStreamEvent)
+
+    expect(mockIndex).toHaveBeenCalledWith(putData)
+  })
+})
+
+describe('testing delete synonymGroup table-stream', () => {
+  test('remove one eventId while leaving others', async () => {
+    const mockItems = [{ synonymId, eventId: existingEventId }]
+    const mockClient = {
+      synonyms: {
+        query: mockQuery,
+      },
+    }
+    mockQuery.mockResolvedValue({ Items: mockItems })
+    ;(tables as unknown as jest.Mock).mockResolvedValue(mockClient)
+    mockStreamEvent.Records[0].eventName = 'REMOVE'
+    putData.body.eventIds = [existingEventId]
+    ;(search as unknown as jest.Mock).mockReturnValue({
+      index: mockIndex,
+      delete: mockDelete,
+    })
+
+    await handler(mockStreamEvent)
+
+    expect(mockIndex).toHaveBeenCalledWith(putData)
+  })
+
+  test('remove final synonym and delete synonym group', async () => {
+    const mockItems = [] as Synonym[]
+    const mockClient = {
+      synonyms: {
+        query: mockQuery,
+      },
+    }
+    mockQuery.mockResolvedValue({ Items: mockItems })
+    ;(tables as unknown as jest.Mock).mockResolvedValue(mockClient)
+    mockStreamEvent.Records[0].eventName = 'REMOVE'
+    const deleteData = {
+      index: 'synonym-groups',
+      id: synonymId,
+    }
+    ;(search as unknown as jest.Mock).mockReturnValue({
+      index: mockIndex,
+      delete: mockDelete,
+    })
+
+    await handler(mockStreamEvent)
+
+    expect(mockDelete).toHaveBeenCalledWith(deleteData)
+  })
+})

app/components/UserLookup.tsx

@@ -0,0 +1,175 @@
+/*!
+ * Copyright © 2023 United States Government as represented by the
+ * Administrator of the National Aeronautics and Space Administration.
+ * All Rights Reserved.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+import { useFetcher } from '@remix-run/react'
+import type { action } from 'app/routes/api.users'
+import classnames from 'classnames'
+import type { UseComboboxProps, UseComboboxStateChange } from 'downshift'
+import { useCombobox } from 'downshift'
+import { debounce } from 'lodash'
+import { useCallback, useEffect, useState } from 'react'
+
+import { formatAuthor } from '~/routes/circulars/circulars.lib'
+
+import loaderImage from 'nasawds/src/img/loader.gif'
+
+export interface UserLookup {
+  sub?: string
+  email: string
+  name?: string
+  affiliation?: string
+}
+
+interface UserComboBoxProps
+  extends Omit<
+    UseComboboxProps<UserLookup>,
+    'items' | 'onInputValueChange' | 'itemToString'
+  > {
+  disabled?: boolean
+  className?: string
+  group?: string
+  onChange?: () => void
+}
+
+interface UserComboBoxHandle {
+  reset?: () => void
+}
+
+export function UserLookupComboBox({
+  disabled,
+  className,
+  group,
+  onChange,
+  // ref,
+  ...props
+}: UserComboBoxProps & UserComboBoxHandle) {
+  const fetcher = useFetcher<typeof action>()
+  const [items, setItems] = useState<UserLookup[]>([])
+
+  useEffect(() => {
+    setItems(fetcher.data?.users ?? [])
+  }, [fetcher.data])
+
+  if (onChange) onChange()
+
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  const onInputValueChange = useCallback(
+    debounce(
+      ({ inputValue, isOpen }: UseComboboxStateChange<UserLookup>) => {
+        if (inputValue && isOpen) {
+          const data = new FormData()
+          data.set('filter', inputValue.split(' ')[0])
+          data.set('intent', 'filter')
+          data.set('group', group ?? '')
+          fetcher.submit(data, { method: 'POST', action: '/api/users' })
+        } else {
+          setItems([])
+        }
+      },
+      500,
+      { trailing: true }
+    ),
+    []
+  )
+
+  const {
+    reset,
+    isOpen,
+    highlightedIndex,
+    selectedItem,
+    getMenuProps,
+    getInputProps,
+    getItemProps,
+    getToggleButtonProps,
+  } = useCombobox<UserLookup>({
+    items,
+    onInputValueChange,
+    itemToString(item) {
+      return item ? formatAuthor(item) : ''
+    },
+    ...props,
+  })
+
+  const loading = fetcher.state === 'submitting'
+  const pristine = Boolean(selectedItem)
+
+  return (
+    <div
+      data-testid="combo-box"
+      data-enhanced="true"
+      className={classnames('usa-combo-box', className, {
+        'usa-combo-box--pristine': pristine || loading,
+      })}
+    >
+      <input
+        autoCapitalize="off"
+        autoComplete="off"
+        className="usa-combo-box__input"
+        disabled={disabled}
+        {...getInputProps()}
+        // Funky escape sequence is a zero-width character to prevent Safari
+        // from attempting to autofill the user's own email address, which
+        // would be triggered by the presence of the string "email" in the
+        // placeholder.
+        placeholder="Name or em&#8203;ail address of user"
+      />
+      <span className="usa-combo-box__clear-input__wrapper" tabIndex={-1}>
+        <button
+          type="button"
+          className="usa-combo-box__clear-input"
+          aria-label="Clear the select contents"
+          style={
+            loading ? { backgroundImage: `url('${loaderImage}')` } : undefined
+          }
+          onClick={() => reset()}
+          hidden={(!pristine || disabled) && !loading}
+          disabled={disabled}
+        >
+          &nbsp;
+        </button>
+      </span>
+      <span className="usa-combo-box__input-button-separator">&nbsp;</span>
+      <span className="usa-combo-box__toggle-list__wrapper" tabIndex={-1}>
+        <button
+          type="button"
+          className="usa-combo-box__toggle-list"
+          {...getToggleButtonProps()}
+        >
+          &nbsp;
+        </button>
+      </span>
+      <ul
+        {...getMenuProps()}
+        className="usa-combo-box__list"
+        role="listbox"
+        hidden={!isOpen}
+      >
+        {isOpen &&
+          (items.length ? (
+            items.map((item, index) => (
+              <li
+                key={item.sub}
+                className={classnames('usa-combo-box__list-option', {
+                  'usa-combo-box__list-option--focused':
+                    index === highlightedIndex,
+                  'usa-combo-box__list-option--selected':
+                    selectedItem?.sub === item.sub,
+                })}
+                {...getItemProps({ item, index })}
+              >
+                {formatAuthor(item)}
+              </li>
+            ))
+          ) : (
+            <li className="usa-combo-box__list-option--no-results">
+              No results found
+            </li>
+          ))}
+      </ul>
+    </div>
+  )
+}

app/email-incoming/circulars/index.ts

@@ -26,7 +26,7 @@
 } from '~/lib/cognito.server'
 import { sendEmail } from '~/lib/email.server'
 import { hostname, origin } from '~/lib/env.server'
-import { group, putRaw } from '~/routes/circulars/circulars.server'
+import { putRaw, submitterGroup } from '~/routes/circulars/circulars.server'
 
 interface UserData {
   email: string
@@ -120,7 +120,7 @@
 async function getCognitoUserData(
   userEmail: string
 ): Promise<UserData | undefined> {
-  const users = await listUsersInGroup(group)
+  const users = await listUsersInGroup(submitterGroup)
   const Attributes = users.find(
     ({ Attributes }) =>
       extractAttributeRequired(Attributes, 'email') == userEmail