Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVOM Mission Page #2499

Closed
wants to merge 74 commits into from
Closed

Conversation

Vidushi-GitHub
Copy link
Member

Description

PR for adding SVOM mission page over GCN website.

SVOM team feedback and .svg logo is requested.

Related Issue(s)

Closing #2175 , as had 200+ merge conflicts.
Vidushi-GitHub#3 is also implemented @https://github.com/timroland

@Vidushi-GitHub
Copy link
Member Author

Attached Mission Page
Screenshot 2024-07-30 at 2 26 21 PM

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a work in progress?

@Vidushi-GitHub Vidushi-GitHub marked this pull request as ready for review August 1, 2024 16:48
| Instrument | Type | Yearly Rates |
| ----------------- | -------------------------------- | ------------ |
| ECLAIRs | GRBs (TBD) | TBD |
| Gamma Ray Monitor | GRBs, and other transients (TBD) | TBD |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(TBD) not needed if it says "and other transients)

Use either full names or acronyms, not a combination, so "Gamma ray Monitor" should be "GRM"

| ---------------------------------- | ----------------------- | ------------- | ---------------------------------------------- |
| ECLAIRs | 4 - 250 keV | 2 ster | ~8' radius (statistical, 90% confidence) |
| Gamma Ray burst Monitor (GRM) | 15 - 5000 keV | 2.6 ster | ~1-10° radius (statistical, 90% confidence) |
| Microchannel X-ray Telescope (MXT) | 15 - 5000 keV | 1.1° x 1.1° | ~10-100'' radius (statistical, 90% confidence) |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timroland please provide the feedback for correct energy range of MXT.

dependabot bot and others added 20 commits October 13, 2024 19:43
Bumps [@architect/plugin-lambda-invoker](https://github.com/architect/plugin-lambda-invoker) from 2.0.0 to 2.0.1.
- [Changelog](https://github.com/architect/plugin-lambda-invoker/blob/main/changelog.md)
- [Commits](architect/plugin-lambda-invoker@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: "@architect/plugin-lambda-invoker"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.5.3 to 5.5.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.3...v5.5.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [husky](https://github.com/typicode/husky) from 9.1.1 to 9.1.3.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.1.1...v9.1.3)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.7 to 15.2.8.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.2.7...v15.2.8)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [isbot](https://github.com/omrilotan/isbot) from 5.1.13 to 5.1.14.
- [Changelog](https://github.com/omrilotan/isbot/blob/main/CHANGELOG.md)
- [Commits](omrilotan/isbot@v5.1.13...v5.1.14)

---
updated-dependencies:
- dependency-name: isbot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.11 to 22.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the remix group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [@remix-run/architect](https://github.com/remix-run/remix/tree/HEAD/packages/remix-architect) | `2.10.3` | `2.11.0` |
| [@remix-run/css-bundle](https://github.com/remix-run/remix/tree/HEAD/packages/remix-css-bundle) | `2.10.3` | `2.11.0` |
| [@remix-run/node](https://github.com/remix-run/remix/tree/HEAD/packages/remix-node) | `2.10.3` | `2.11.0` |
| [@remix-run/react](https://github.com/remix-run/remix/tree/HEAD/packages/remix-react) | `2.10.3` | `2.11.0` |
| [@remix-run/dev](https://github.com/remix-run/remix/tree/HEAD/packages/remix-dev) | `2.10.3` | `2.11.0` |
| [@remix-run/eslint-config](https://github.com/remix-run/remix/tree/HEAD/packages/remix-eslint-config) | `2.10.3` | `2.11.0` |


Updates `@remix-run/architect` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-architect/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-architect)

Updates `@remix-run/css-bundle` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-css-bundle/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-css-bundle)

Updates `@remix-run/node` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-node/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-node)

Updates `@remix-run/react` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-react/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-react)

Updates `@remix-run/dev` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-dev/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-dev)

Updates `@remix-run/eslint-config` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-eslint-config/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-eslint-config)

---
updated-dependencies:
- dependency-name: "@remix-run/architect"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: remix
- dependency-name: "@remix-run/css-bundle"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: remix
- dependency-name: "@remix-run/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: remix
- dependency-name: "@remix-run/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: remix
- dependency-name: "@remix-run/dev"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: remix
- dependency-name: "@remix-run/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: remix
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@opensearch-project/opensearch](https://github.com/opensearch-project/opensearch-js) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/opensearch-project/opensearch-js/releases)
- [Changelog](https://github.com/opensearch-project/opensearch-js/blob/main/CHANGELOG.md)
- [Commits](opensearch-project/opensearch-js@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: "@opensearch-project/opensearch"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.19 to 10.4.20.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.19...10.4.20)

---
updated-dependencies:
- dependency-name: autoprefixer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the remix group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [@remix-run/architect](https://github.com/remix-run/remix/tree/HEAD/packages/remix-architect) | `2.11.0` | `2.11.1` |
| [@remix-run/css-bundle](https://github.com/remix-run/remix/tree/HEAD/packages/remix-css-bundle) | `2.11.0` | `2.11.1` |
| [@remix-run/node](https://github.com/remix-run/remix/tree/HEAD/packages/remix-node) | `2.11.0` | `2.11.1` |
| [@remix-run/react](https://github.com/remix-run/remix/tree/HEAD/packages/remix-react) | `2.11.0` | `2.11.1` |
| [@remix-run/dev](https://github.com/remix-run/remix/tree/HEAD/packages/remix-dev) | `2.11.0` | `2.11.1` |
| [@remix-run/eslint-config](https://github.com/remix-run/remix/tree/HEAD/packages/remix-eslint-config) | `2.11.0` | `2.11.1` |


Updates `@remix-run/architect` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-architect/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-architect)

Updates `@remix-run/css-bundle` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-css-bundle/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-css-bundle)

Updates `@remix-run/node` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-node/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-node)

Updates `@remix-run/react` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-react/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-react)

Updates `@remix-run/dev` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-dev/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-dev)

Updates `@remix-run/eslint-config` from 2.11.0 to 2.11.1
- [Release notes](https://github.com/remix-run/remix/releases)
- [Changelog](https://github.com/remix-run/remix/blob/main/packages/remix-eslint-config/CHANGELOG.md)
- [Commits](https://github.com/remix-run/remix/commits/@remix-run/[email protected]/packages/remix-eslint-config)

---
updated-dependencies:
- dependency-name: "@remix-run/architect"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: remix
- dependency-name: "@remix-run/css-bundle"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: remix
- dependency-name: "@remix-run/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: remix
- dependency-name: "@remix-run/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: remix
- dependency-name: "@remix-run/dev"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: remix
- dependency-name: "@remix-run/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: remix
...

Signed-off-by: dependabot[bot] <[email protected]>
dakota002 and others added 20 commits October 13, 2024 19:43
Bumps [husky](https://github.com/typicode/husky) from 9.1.4 to 9.1.6.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v9.1.4...v9.1.6)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.0 to 22.5.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps  and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). These dependencies needed to be updated together.

Updates `vite` from 5.4.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

Updates `vite` from 4.5.3 to 5.4.6
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
- dependency-name: vite
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
… changes if they exist (nasa-gcn#2585)

* Updates the change request form to populate with previously requested changes if they exist

* throw all but the 404, types on zendeskticketId

* Apply type narrowing

* Update function to throw error and just return Id

* Update app/lib/zendesk.server.ts

Co-authored-by: Leo Singer <[email protected]>

* Update app/routes/circulars._archive._index/route.tsx

Co-authored-by: Leo Singer <[email protected]>

* Add final check for undefined

* Prettier on zendesk server

---------

Co-authored-by: Leo Singer <[email protected]>
Bumps  and [rollup](https://github.com/rollup/rollup). These dependencies needed to be updated together.

Updates `rollup` from 4.21.2 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

Updates `rollup` from 3.29.4 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 16.0.0 to 16.0.1.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v16.0.0...v16.0.1)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.4...v5.6.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 8.56.0 to 8.57.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.56.0...v8.57.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/color-convert](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/color-convert) from 2.0.1 to 2.0.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/color-convert)

---
updated-dependencies:
- dependency-name: "@types/color-convert"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 7.34266% with 265 lines in your changes missing coverage. Please review.

Project coverage is 6.08%. Comparing base (46ec6cc) to head (6ce4341).
Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/admin.users.$userId.tsx 0.00% 43 Missing ⚠️
app/routes/circulars/circulars.server.ts 0.00% 38 Missing ⚠️
app/components/UserLookup.tsx 0.00% 31 Missing ⚠️
app/routes/api.users.ts 0.00% 29 Missing ⚠️
app/lib/cognito.server.ts 22.85% 27 Missing ⚠️
app/routes/admin.users._index.tsx 0.00% 22 Missing ⚠️
app/lib/zendesk.server.ts 0.00% 11 Missing ⚠️
app/routes/admin.tsx 0.00% 11 Missing ⚠️
...routes/user.email._index/EmailNotificationCard.tsx 0.00% 9 Missing ⚠️
app/routes/circulars.correction.$circularId.tsx 0.00% 7 Missing ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2499      +/-   ##
========================================
+ Coverage   5.27%   6.08%   +0.81%     
========================================
  Files        157     164       +7     
  Lines       3906    4073     +167     
  Branches     419     450      +31     
========================================
+ Hits         206     248      +42     
- Misses      3699    3823     +124     
- Partials       1       2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vidushi-GitHub
Copy link
Member Author

Screenshot 2024-10-13 at 23 25 04 Screenshot 2024-10-13 at 23 25 13

@timroland could you please check the content/

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR touches lots of unrelated files. This looks like an incomplete rebase attempt.

@Vidushi-GitHub
Copy link
Member Author

This PR touches lots of unrelated files. This looks like an incomplete rebase attempt.

Yes, I din't squash properly. Shall I close this and make a fresh PR or rebase again?

@lpsinger
Copy link
Member

This PR touches lots of unrelated files. This looks like an incomplete rebase attempt.

Yes, I din't squash properly. Shall I close this and make a fresh PR or rebase again?

Whatever you know how to do and are comfortable with.

@Vidushi-GitHub
Copy link
Member Author

#2637 PR is opened.

@Vidushi-GitHub Vidushi-GitHub deleted the svom/missionpage branch October 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants