C bindings for verkle #477

Richa-iitr · 2024-10-06T16:34:15Z

Added C bindings for verkle-ipa.

mratsim

Thanks for the contributions.

I think this should be split into 3 steps:

C bindings for banderwagon fr, fp, ec
Creating a proper wrapper for the Ethereumn specific instantiation of IPA. Currently the generic code is forwarded (i.e. constantine/commitments/eth_verkle_ipa.nim) but protocol-specific constants/types should be wrapped and exposed in a proper procedure in the root constantine/eth_verkle_ipa.nim and only there can C bindings be generated from.
Actually do the C bindings.

include/constantine/protocols/ethereum_verkle_ipa.h

constantine/ethereum_verkle_ipa.nim

mratsim · 2024-10-07T08:30:44Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct Fr Fr;
+typedef struct Banderwagon Banderwagon;
+typedef struct EC_TwEdw EC_TwEdw;
+typedef struct Fp Fp;


All the fields and curves related struct should be defined in constantine/include/constantine/curves/banderwagon.h

This would be similar to pallas and vesta as they don't use pairings:

constantine/bindings/lib_curves.nim

Lines 68 to 100 in 2c3de87

type

bn254_snarks_fr = Fr[BN254_Snarks]

bn254_snarks_fp = Fp[BN254_Snarks]

bn254_snarks_fp2 = Fp2[BN254_Snarks]

bn254_snarks_g1_aff = EC_ShortW_Aff[Fp[BN254_Snarks], G1]

bn254_snarks_g1_jac = EC_ShortW_Jac[Fp[BN254_Snarks], G1]

bn254_snarks_g1_prj = EC_ShortW_Prj[Fp[BN254_Snarks], G1]

bn254_snarks_g2_aff = EC_ShortW_Aff[Fp2[BN254_Snarks], G2]

bn254_snarks_g2_jac = EC_ShortW_Jac[Fp2[BN254_Snarks], G2]

bn254_snarks_g2_prj = EC_ShortW_Prj[Fp2[BN254_Snarks], G2]

collectBindings(cBindings_bn254_snarks):

genBindingsField(big254, bn254_snarks_fr)

genBindingsField(big254, bn254_snarks_fp)

genBindingsFieldSqrt(bn254_snarks_fp)

genBindingsExtField(bn254_snarks_fp2)

genBindingsExtFieldSqrt(bn254_snarks_fp2)

genBindings_EC_ShortW_Affine(bn254_snarks_g1_aff, bn254_snarks_fp)

genBindings_EC_ShortW_NonAffine(bn254_snarks_g1_jac, bn254_snarks_g1_aff, big254, bn254_snarks_fr)

genBindings_EC_ShortW_NonAffine(bn254_snarks_g1_prj, bn254_snarks_g1_aff, big254, bn254_snarks_fr)

genBindings_EC_ShortW_Affine(bn254_snarks_g2_aff, bn254_snarks_fp2)

genBindings_EC_ShortW_NonAffine(bn254_snarks_g2_jac, bn254_snarks_g2_aff, big254, bn254_snarks_fr)

genBindings_EC_ShortW_NonAffine(bn254_snarks_g2_prj, bn254_snarks_g2_aff, big254, bn254_snarks_fr)

genBindings_EC_hash_to_curve(bn254_snarks_g1_aff, svdw, sha256, k = 128)

genBindings_EC_hash_to_curve(bn254_snarks_g1_jac, svdw, sha256, k = 128)

genBindings_EC_hash_to_curve(bn254_snarks_g1_prj, svdw, sha256, k = 128)

genBindings_EC_hash_to_curve(bn254_snarks_g2_aff, svdw, sha256, k = 128)

genBindings_EC_hash_to_curve(bn254_snarks_g2_jac, svdw, sha256, k = 128)

genBindings_EC_hash_to_curve(bn254_snarks_g2_prj, svdw, sha256, k = 128)

collectBindings(cBindings_bn254_snarks_parallel):

genParallelBindings_EC_ShortW_NonAffine(bn254_snarks_g1_jac, bn254_snarks_g1_aff, bn254_snarks_fr)

genParallelBindings_EC_ShortW_NonAffine(bn254_snarks_g1_prj, bn254_snarks_g1_aff, bn254_snarks_fr)

However Banderwagon is an Edwards curve so the template there might need an adaptation.
I don't remember what I add in mind as differences between short-weierstrass and twisted edwards, maybe it was just the affine<->jacobian<->projective coordinate conversion and that could be done as a separate template, see

constantine/bindings/c_curve_decls.nim

Lines 314 to 432 in 2c3de87

template genBindings_EC_ShortW_Affine*(EC, Field: untyped) =

when appType == "lib":

{.push noconv, dynlib, exportc, raises: [].} # No exceptions allowed

else:

{.push noconv, exportc, raises: [].} # No exceptions allowed

# --------------------------------------------------------------------------------------

func `ctt _ EC _ is_eq`(P, Q: EC): SecretBool =

P == Q

func `ctt _ EC _ is_neutral`(P: EC): SecretBool =

P.isNeutral()

func `ctt _ EC _ set_neutral`(P: var EC) =

P.setNeutral()

func `ctt _ EC _ ccopy`(P: var EC, Q: EC, ctl: SecretBool) =

P.ccopy(Q, ctl)

func `ctt _ EC _ is_on_curve`(x, y: Field): SecretBool =

isOnCurve(x, y, EC.G)

func `ctt _ EC _ neg`(P: var EC, Q: EC) =

P.neg(Q)

func `ctt _ EC _ neg_in_place`(P: var EC) =

P.neg()

{.pop.}

template genBindings_EC_ShortW_NonAffine*(EC, EcAff, ScalarBig, ScalarField: untyped) =

# TODO: remove the need of explicit ScalarBig and ScalarField

when appType == "lib":

{.push noconv, dynlib, exportc, raises: [].} # No exceptions allowed

else:

{.push noconv, exportc, raises: [].} # No exceptions allowed

# --------------------------------------------------------------------------------------

func `ctt _ EC _ is_eq`(P, Q: EC): SecretBool =

P == Q

func `ctt _ EC _ is_neutral`(P: EC): SecretBool =

P.isNeutral()

func `ctt _ EC _ set_neutral`(P: var EC) =

P.setNeutral()

func `ctt _ EC _ ccopy`(P: var EC, Q: EC, ctl: SecretBool) =

P.ccopy(Q, ctl)

func `ctt _ EC _ neg`(P: var EC, Q: EC) =

P.neg(Q)

func `ctt _ EC _ neg_in_place`(P: var EC) =

P.neg()

func `ctt _ EC _ cneg_in_place`(P: var EC, ctl: SecretBool) =

P.neg()

func `ctt _ EC _ sum`(r: var EC, P, Q: EC) =

r.sum(P, Q)

func `ctt _ EC _ add_in_place`(P: var EC, Q: EC) =

P += Q

func `ctt _ EC _ diff`(r: var EC, P, Q: EC) =

r.diff(P, Q)

func `ctt _ EC _ double`(r: var EC, P: EC) =

r.double(P)

func `ctt _ EC _ double_in_place`(P: var EC) =

P.double()

func `ctt _ EC _ affine`(dst: var EcAff, src: EC) =

dst.affine(src)

func `ctt _ EC _ from_affine`(dst: var EC, src: EcAff) =

dst.fromAffine(src)

func `ctt _ EC _ batch_affine`(dst: ptr UncheckedArray[EcAff], src: ptr UncheckedArray[EC], n: csize_t) =

dst.batchAffine(src, cast[int](n))

func `ctt _ EC _ scalar_mul_big_coef`(

P: var EC, scalar: ScalarBig) =

P.scalarMul(scalar)

func `ctt _ EC _ scalar_mul_fr_coef`(

P: var EC, scalar: ScalarField) =

P.scalarMul(scalar)

func `ctt _ EC _ scalar_mul_big_coef_vartime`(

P: var EC, scalar: ScalarBig) =

P.scalarMul_vartime(scalar)

func `ctt _ EC _ scalar_mul_fr_coef_vartime`(

P: var EC, scalar: ScalarField) =

P.scalarMul_vartime(scalar)

func `ctt _ EC _ multi_scalar_mul_big_coefs_vartime`(

r: var EC,

coefs: ptr UncheckedArray[ScalarBig],

points: ptr UncheckedArray[EcAff],

len: csize_t) =

r.multiScalarMul_vartime(coefs, points, cast[int](len))

func `ctt _ EC _ multi_scalar_mul_fr_coefs_vartime`(

r: var EC,

coefs: ptr UncheckedArray[ScalarField],

points: ptr UncheckedArray[EcAff],

len: csize_t)=

r.multiScalarMul_vartime(coefs, points, cast[int](len))

{.pop.}

@mratsim i resolved this and added separate header for banderwagon. Please review and suggest changes. Also how can i verify things are working as expected?

Good question, I don't have a testsuite for the C API of elliptic curves. It's not ideal but for now we can skip it merge as-is and focus on the C API for the full protocol.

mratsim · 2024-10-07T08:35:11Z

include/constantine/protocols/ethereum_verkle_ipa.h

+    uint32_t u32;
+    uint64_t u64;
+    unsigned int u;
+} SomeUnsignedInt;


You cannot emulate generics with union types.

Whatever the platform, the storage reserved will be 64-bit / 8 bytes per entry here.
But if Nim uses 32-bit inputs in an array a, the C code will read both entries with a[0] and will read past the buffer with a[1].

Hence generic procedures cannot be wrapped in C directly.

Understood, will think of another way here.

mratsim · 2024-10-07T08:38:03Z

constantine/commitments/eth_verkle_ipa.nim

@@ -139,7 +143,7 @@ func innerProduct[F](r: var F, a, b: distinct(View[F] or MutableView[F])) =
 func ipa_commit*[N: static int, EC, F](
      crs: PolynomialEval[N, EC],
      r: var EC,
-      poly: PolynomialEval[N, F]) =
+      poly: PolynomialEval[N, F]) {.libPrefix: prefix_ipa.} =


This is not the proper level of exports as this is a generic procedure.

Export should happen at fully specified protocol level (i.e. curve, field, hash functions, N: static int input sizes are known).

In this case, this means having proper instantiated ipa_commit here:

constantine/constantine/ethereum_verkle_ipa.nim

Lines 285 to 292 in 2c3de87

# TODO: proper IPA wrapper for https://github.com/status-im/nim-eth-verkle

#

# For now we reexport

# - eth_verkle_ipa

# - sha256 for transcripts

export eth_verkle_ipa

export hashes

and tagging those with libPrefix.

is there any example of a wrapper i can follow to understand?
If i am not wrong something like this

constantine/constantine/ethereum_verkle_ipa.nim

Lines 230 to 245 in 2c3de87

func mapToScalarField*(res: var Fr[Banderwagon], p: EC_TwEdw[Fp[Banderwagon]]): bool {.discardable.} =

## This function takes the x/y value from the above function as Fp element

## and convert that to bytes in Big Endian,

## and then load that to a Fr element

##

## Spec : https://hackmd.io/wliPP_RMT4emsucVuCqfHA?view#MapToFieldElement

var baseField: Fp[Banderwagon]

var baseFieldBytes: array[32, byte]

baseField.mapToBaseField(p) # compute the defined mapping

let check1 = baseFieldBytes.marshalBE(baseField) # Fp -> bytes

let check2 = res.unmarshalBE(baseFieldBytes) # bytes -> Fr

return check1 and check2

can be exported directly?

Yes, anything with generics cannot be exported and need a concretely typed wrapper.

mratsim · 2024-10-07T08:40:06Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct {
+    byte x[32];  // 32-byte x-coordinate
+    byte y[32];  // 32-byte y-coordinate
+} EC_TwEdw_Fp_Banderwagon;


mratsim · 2024-10-07T08:40:11Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct {
+    byte x[32];  // 32-byte x-coordinate
+    byte y[32];  // 32-byte y-coordinate
+} EC;


mratsim · 2024-10-07T08:41:42Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct {
+    EC* points;  
+    size_t length;  
+} PolynomialEval_EC;


the protocol has fixed size polynomials. Nim static int are similar to generics and cannot be represented with C runtime parameters. Instead a no generic/no static procedure should be implemented at the croot of the project in constantine/ethereum_verkle_ipa.nim

mratsim · 2024-10-07T08:41:59Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct {
+    EC* ec_points;  
+    size_t length;                       
+} EcAffArray;


ditto for all structs up to here

mratsim · 2024-10-07T08:46:55Z

include/constantine/protocols/ethereum_verkle_ipa.h

+typedef struct EthVerkleTranscript EthVerkleTranscript;
+
+typedef byte EthVerkleIpaProofBytes[544];       // Array of 544 bytes
+typedef byte EthVerkleIpaMultiProofBytes[576]; 


It's more useful to provide:

either ctt_eth_verkle_ipa_proof_sizeof() and ctt_eth_verkle_ipa_multiproof_sizeof() and let the caller do their allocation / destruction

or ctt_eth_verkle_ipa_proof_create() / ctt_eth_verkle_ipa_proof_destroy()
and ctt_eth_verkle_ipa_multiproof_create() / ctt_eth_verkle_ipa_multiproof_destroy()

Co-authored-by: Mamy Ratsimbazafy <[email protected]>

mratsim

The PR looks good for a merge if we remove the protocols/ethereum_verkle_ipa.h. Its rewrite can be done separately.

Co-authored-by: Mamy Ratsimbazafy <[email protected]>

…antine into verkle_bindings

Richa-iitr · 2024-10-28T15:44:10Z

The PR looks good for a merge if we remove the protocols/ethereum_verkle_ipa.h. Its rewrite can be done separately.

removed the file, please review

c bindings for verkle

ebd2d93

Richa-iitr marked this pull request as draft October 6, 2024 16:34

mratsim reviewed Oct 7, 2024

View reviewed changes

Richa-iitr and others added 9 commits October 7, 2024 21:01

comments correction

d2aac24

Co-authored-by: Mamy Ratsimbazafy <[email protected]>

refactoring:

664de50

curve decl for ed

4209411

gen bindings for twedw

42624ff

bigint bandderwagon types

ed100a6

banderwagon header

51d5372

undo exportc of generic functions

3667f27

add scalar mul

2003342

more exports for banderwagon scalar mul

b283079

mratsim previously approved these changes Oct 27, 2024

View reviewed changes

Richa-iitr and others added 10 commits October 27, 2024 22:09

c bindings for verkle

e4f40fc

comments correction

66d9abf

Co-authored-by: Mamy Ratsimbazafy <[email protected]>

refactoring:

d3097e4

curve decl for ed

bc0db22

gen bindings for twedw

e248847

bigint bandderwagon types

f861325

banderwagon header

c8ed6d3

undo exportc of generic functions

cc17062

add scalar mul

9457566

more exports for banderwagon scalar mul

a87638b

mratsim force-pushed the verkle_bindings branch from b283079 to a87638b Compare October 27, 2024 21:09

Richa-iitr added 2 commits October 28, 2024 21:03

Merge branch 'verkle_bindings' of https://github.com/Richa-iitr/const…

f8d649e

…antine into verkle_bindings

remove verkle header file changes

078ea23

Richa-iitr dismissed mratsim’s stale review via 078ea23 October 28, 2024 15:42

agnxsh marked this pull request as ready for review November 10, 2024 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C bindings for verkle #477

C bindings for verkle #477

Richa-iitr commented Oct 6, 2024

mratsim left a comment

mratsim Oct 7, 2024

Richa-iitr Oct 20, 2024

mratsim Oct 27, 2024

mratsim Oct 7, 2024

Richa-iitr Oct 7, 2024

mratsim Oct 7, 2024

Richa-iitr Oct 20, 2024 •

edited

Loading

mratsim Oct 24, 2024

mratsim Oct 7, 2024

mratsim Oct 7, 2024

mratsim Oct 7, 2024

mratsim Oct 7, 2024

mratsim Oct 7, 2024

mratsim left a comment

Richa-iitr commented Oct 28, 2024

	type
	bn254_snarks_fr = Fr[BN254_Snarks]
	bn254_snarks_fp = Fp[BN254_Snarks]
	bn254_snarks_fp2 = Fp2[BN254_Snarks]
	bn254_snarks_g1_aff = EC_ShortW_Aff[Fp[BN254_Snarks], G1]
	bn254_snarks_g1_jac = EC_ShortW_Jac[Fp[BN254_Snarks], G1]
	bn254_snarks_g1_prj = EC_ShortW_Prj[Fp[BN254_Snarks], G1]
	bn254_snarks_g2_aff = EC_ShortW_Aff[Fp2[BN254_Snarks], G2]
	bn254_snarks_g2_jac = EC_ShortW_Jac[Fp2[BN254_Snarks], G2]
	bn254_snarks_g2_prj = EC_ShortW_Prj[Fp2[BN254_Snarks], G2]

	collectBindings(cBindings_bn254_snarks):
	genBindingsField(big254, bn254_snarks_fr)
	genBindingsField(big254, bn254_snarks_fp)
	genBindingsFieldSqrt(bn254_snarks_fp)
	genBindingsExtField(bn254_snarks_fp2)
	genBindingsExtFieldSqrt(bn254_snarks_fp2)
	genBindings_EC_ShortW_Affine(bn254_snarks_g1_aff, bn254_snarks_fp)
	genBindings_EC_ShortW_NonAffine(bn254_snarks_g1_jac, bn254_snarks_g1_aff, big254, bn254_snarks_fr)
	genBindings_EC_ShortW_NonAffine(bn254_snarks_g1_prj, bn254_snarks_g1_aff, big254, bn254_snarks_fr)
	genBindings_EC_ShortW_Affine(bn254_snarks_g2_aff, bn254_snarks_fp2)
	genBindings_EC_ShortW_NonAffine(bn254_snarks_g2_jac, bn254_snarks_g2_aff, big254, bn254_snarks_fr)
	genBindings_EC_ShortW_NonAffine(bn254_snarks_g2_prj, bn254_snarks_g2_aff, big254, bn254_snarks_fr)
	genBindings_EC_hash_to_curve(bn254_snarks_g1_aff, svdw, sha256, k = 128)
	genBindings_EC_hash_to_curve(bn254_snarks_g1_jac, svdw, sha256, k = 128)
	genBindings_EC_hash_to_curve(bn254_snarks_g1_prj, svdw, sha256, k = 128)
	genBindings_EC_hash_to_curve(bn254_snarks_g2_aff, svdw, sha256, k = 128)
	genBindings_EC_hash_to_curve(bn254_snarks_g2_jac, svdw, sha256, k = 128)
	genBindings_EC_hash_to_curve(bn254_snarks_g2_prj, svdw, sha256, k = 128)

	collectBindings(cBindings_bn254_snarks_parallel):
	genParallelBindings_EC_ShortW_NonAffine(bn254_snarks_g1_jac, bn254_snarks_g1_aff, bn254_snarks_fr)
	genParallelBindings_EC_ShortW_NonAffine(bn254_snarks_g1_prj, bn254_snarks_g1_aff, bn254_snarks_fr)

	template genBindings_EC_ShortW_Affine*(EC, Field: untyped) =
	when appType == "lib":
	{.push noconv, dynlib, exportc, raises: [].} # No exceptions allowed
	else:
	{.push noconv, exportc, raises: [].} # No exceptions allowed

	# --------------------------------------------------------------------------------------
	func `ctt _ EC _ is_eq`(P, Q: EC): SecretBool =
	P == Q

	func `ctt _ EC _ is_neutral`(P: EC): SecretBool =
	P.isNeutral()

	func `ctt _ EC _ set_neutral`(P: var EC) =
	P.setNeutral()

	func `ctt _ EC _ ccopy`(P: var EC, Q: EC, ctl: SecretBool) =
	P.ccopy(Q, ctl)

	func `ctt _ EC _ is_on_curve`(x, y: Field): SecretBool =
	isOnCurve(x, y, EC.G)

	func `ctt _ EC _ neg`(P: var EC, Q: EC) =
	P.neg(Q)

	func `ctt _ EC _ neg_in_place`(P: var EC) =
	P.neg()

	{.pop.}

	template genBindings_EC_ShortW_NonAffine*(EC, EcAff, ScalarBig, ScalarField: untyped) =
	# TODO: remove the need of explicit ScalarBig and ScalarField

	when appType == "lib":
	{.push noconv, dynlib, exportc, raises: [].} # No exceptions allowed
	else:
	{.push noconv, exportc, raises: [].} # No exceptions allowed

	# --------------------------------------------------------------------------------------
	func `ctt _ EC _ is_eq`(P, Q: EC): SecretBool =
	P == Q

	func `ctt _ EC _ is_neutral`(P: EC): SecretBool =
	P.isNeutral()

	func `ctt _ EC _ set_neutral`(P: var EC) =
	P.setNeutral()

	func `ctt _ EC _ ccopy`(P: var EC, Q: EC, ctl: SecretBool) =
	P.ccopy(Q, ctl)

	func `ctt _ EC _ neg`(P: var EC, Q: EC) =
	P.neg(Q)

	func `ctt _ EC _ neg_in_place`(P: var EC) =
	P.neg()

	func `ctt _ EC _ cneg_in_place`(P: var EC, ctl: SecretBool) =
	P.neg()

	func `ctt _ EC _ sum`(r: var EC, P, Q: EC) =
	r.sum(P, Q)

	func `ctt _ EC _ add_in_place`(P: var EC, Q: EC) =
	P += Q

	func `ctt _ EC _ diff`(r: var EC, P, Q: EC) =
	r.diff(P, Q)

	func `ctt _ EC _ double`(r: var EC, P: EC) =
	r.double(P)

	func `ctt _ EC _ double_in_place`(P: var EC) =
	P.double()

	func `ctt _ EC _ affine`(dst: var EcAff, src: EC) =
	dst.affine(src)

	func `ctt _ EC _ from_affine`(dst: var EC, src: EcAff) =
	dst.fromAffine(src)

	func `ctt _ EC _ batch_affine`(dst: ptr UncheckedArray[EcAff], src: ptr UncheckedArray[EC], n: csize_t) =
	dst.batchAffine(src, cast[int](n))

	func `ctt _ EC _ scalar_mul_big_coef`(
	P: var EC, scalar: ScalarBig) =

	P.scalarMul(scalar)

	func `ctt _ EC _ scalar_mul_fr_coef`(
	P: var EC, scalar: ScalarField) =

	P.scalarMul(scalar)

	func `ctt _ EC _ scalar_mul_big_coef_vartime`(
	P: var EC, scalar: ScalarBig) =

	P.scalarMul_vartime(scalar)

	func `ctt _ EC _ scalar_mul_fr_coef_vartime`(
	P: var EC, scalar: ScalarField) =

	P.scalarMul_vartime(scalar)

	func `ctt _ EC _ multi_scalar_mul_big_coefs_vartime`(
	r: var EC,
	coefs: ptr UncheckedArray[ScalarBig],
	points: ptr UncheckedArray[EcAff],
	len: csize_t) =
	r.multiScalarMul_vartime(coefs, points, cast[int](len))

	func `ctt _ EC _ multi_scalar_mul_fr_coefs_vartime`(
	r: var EC,
	coefs: ptr UncheckedArray[ScalarField],
	points: ptr UncheckedArray[EcAff],
	len: csize_t)=
	r.multiScalarMul_vartime(coefs, points, cast[int](len))

	{.pop.}

	# TODO: proper IPA wrapper for https://github.com/status-im/nim-eth-verkle
	#
	# For now we reexport
	# - eth_verkle_ipa
	# - sha256 for transcripts

	export eth_verkle_ipa
	export hashes

	func mapToScalarField*(res: var Fr[Banderwagon], p: EC_TwEdw[Fp[Banderwagon]]): bool {.discardable.} =
	## This function takes the x/y value from the above function as Fp element
	## and convert that to bytes in Big Endian,
	## and then load that to a Fr element
	##
	## Spec : https://hackmd.io/wliPP_RMT4emsucVuCqfHA?view#MapToFieldElement

	var baseField: Fp[Banderwagon]
	var baseFieldBytes: array[32, byte]

	baseField.mapToBaseField(p) # compute the defined mapping

	let check1 = baseFieldBytes.marshalBE(baseField) # Fp -> bytes
	let check2 = res.unmarshalBE(baseFieldBytes) # bytes -> Fr

	return check1 and check2

C bindings for verkle #477

Are you sure you want to change the base?

C bindings for verkle #477

Conversation

Richa-iitr commented Oct 6, 2024

mratsim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Richa-iitr Oct 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mratsim left a comment

Choose a reason for hiding this comment

Richa-iitr commented Oct 28, 2024

Richa-iitr Oct 20, 2024 •

edited

Loading