Skip to content

Commit

Permalink
Fixes for Nim v2.2 (#476)
Browse files Browse the repository at this point in the history
* CI: echo scheduled commands

* ci: revert echo scheduled command + don't create pipe for any != 1.6 branch

* no LTO for windows 2.2, impossible constraint in deneb_kzg test

* ci: typo on CTT_LTO
  • Loading branch information
mratsim authored Oct 7, 2024
1 parent 4a2dd28 commit 2c3de87
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -372,12 +372,13 @@ jobs:
# So "test_bindings" uses C and can find GMP
# but nim-gmp cannot find GMP on Windows CI
# Also need to workaround asynctools not being able to create pipes https://github.com/nim-lang/Nim/issues/23118
# And LTO impossible constraint in the deneb_kzg test (but not MSM for some reason)
if: runner.os == 'Windows' && matrix.target.BACKEND == 'ASM'
shell: msys2 {0}
run: |
cd constantine
if [[ '${{ matrix.nim_version }}' == 'version-2-0' ]]; then
nimble test_no_gmp --verbose
if [[ '${{ matrix.nim_version }}' != 'version-1-6' ]]; then
CTT_LTO=0 nimble test_no_gmp --verbose
else
nimble test_parallel_no_gmp --verbose
fi
Expand All @@ -389,8 +390,8 @@ jobs:
shell: msys2 {0}
run: |
cd constantine
if [[ '${{ matrix.nim_version }}' == 'version-2-0' ]]; then
CTT_ASM=0 nimble test_no_gmp --verbose
if [[ '${{ matrix.nim_version }}' != 'version-1-6' ]]; then
CTT_ASM=0 CTT_LTO=0 nimble test_no_gmp --verbose
else
CTT_ASM=0 nimble test_parallel_no_gmp --verbose
fi
2 changes: 1 addition & 1 deletion helpers/pararun.nim
Original file line number Diff line number Diff line change
Expand Up @@ -191,4 +191,4 @@ proc main() =
runCommands(commandFile, numWorkers)

when isMainModule:
main()
main()

0 comments on commit 2c3de87

Please sign in to comment.