Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current locale during form create or edit #244

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Oct 8, 2024

Should be released as 2.10.0 version ?

Add way to know the current locale in form

Create UI Element

Sent in the query string :

image

Set in data-locale attribute on the form object :

image

Update Ui Element

Sent in post :

image

Set in data-locale attribute on the form object :

image

@madamebiz madamebiz added the Status: needs review Status: needs review label Oct 8, 2024
@maximehuran maximehuran marked this pull request as ready for review October 8, 2024 11:42
Copy link
Member

@delyriand delyriand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be released as 2.10.0 version ?

I think yes, because the controller and template are changed

@maximehuran maximehuran merged commit 63ad8a1 into monsieurbiz:master Oct 8, 2024
10 checks passed
@maximehuran maximehuran deleted the feature/add-locale branch October 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: needs review Status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants