Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Unit tests. #717

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Fix broken Unit tests. #717

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d94e87b
Remove `TGSR_test` from tests
ccl-core Jul 19, 2024
83dc311
Move audio_test to hermetic tests
ccl-core Jul 19, 2024
91cf915
Add soxr==0.4.0b1 dep to pyproject.toml
ccl-core Jul 19, 2024
2819d28
Move soxr dep to audio-specific deps
ccl-core Jul 19, 2024
c4eb694
Add comment to pyproject with the fix
ccl-core Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions python/mlcroissant/mlcroissant/_src/datasets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def load_records_and_test_equality(
@pytest.mark.parametrize(
["dataset_name", "record_set_name", "num_records"],
[
["audio_test/metadata.json", "records", 2],
["coco2014-mini/metadata.json", "bounding_boxes", -1],
["coco2014-mini/metadata.json", "captions", -1],
["coco2014-mini/metadata.json", "images", -1],
Expand Down Expand Up @@ -164,11 +165,6 @@ def test_hermetic_loading(version, dataset_name, record_set_name, num_records):
["huggingface-c4/metadata.json", "en", 1],
["huggingface-mnist/metadata.json", "default", 10],
["titanic/metadata.json", "passengers", -1],
[
"audio_test/metadata.json",
"records",
10,
],
],
)
def test_nonhermetic_loading(version, dataset_name, record_set_name, num_records):
Expand All @@ -181,7 +177,6 @@ def test_nonhermetic_loading(version, dataset_name, record_set_name, num_records
["dataset_name", "record_set_name", "num_records"],
[
["huggingface-anthropic-hh-rlhf/metadata.json", "red-team-attempts", 10],
["huggingface-tgqa/metadata.json", "TGSR_test", 10],
],
)
def test_nonhermetic_loading_1_0(dataset_name, record_set_name, num_records):
Expand Down
5 changes: 4 additions & 1 deletion python/mlcroissant/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ dev = [
"pytype",
"torchdata",
]
audio = ["librosa"]
audio = [
"librosa",
"soxr==0.4.0b1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with the fix: librosa/librosa#1831 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

]
git = ["GitPython"]
image = ["Pillow"]
parquet = ["pyarrow"]
Expand Down
Loading