Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Unit tests. #717

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Fix broken Unit tests. #717

merged 5 commits into from
Jul 19, 2024

Conversation

ccl-core
Copy link
Contributor

@ccl-core ccl-core commented Jul 19, 2024

Fix errors in dataset_test.py:

  • Remove TGSR_test from test_nonhermetic_loading_1_0, it is failing because underlying data changed.
  • Move audio_test to test_hermetic_loading as it doesn't contain data from the internet.
  • Added soxr==0.4.0b1 dependency to pyproject.toml to solve an issue with librosa

Copy link

github-actions bot commented Jul 19, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ccl-core ccl-core marked this pull request as ready for review July 19, 2024 09:46
@ccl-core ccl-core requested a review from a team as a code owner July 19, 2024 09:46
@ccl-core ccl-core requested a review from marcenacp July 19, 2024 09:50
audio = ["librosa"]
audio = [
"librosa",
"soxr==0.4.0b1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with the fix: librosa/librosa#1831 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@ccl-core ccl-core merged commit 10d5e04 into main Jul 19, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@ccl-core ccl-core deleted the ccl-core-5 branch July 22, 2024 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants