Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix#534] IndexError / Worker initialization sets wrong last_file_index #535

Merged
merged 6 commits into from
Nov 2, 2023
Merged

[Fix#534] IndexError / Worker initialization sets wrong last_file_index #535

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ac68a1
Run workflow
baterflyrity Sep 30, 2023
0db9235
Add test for issue 534
baterflyrity Sep 30, 2023
e10f52d
Fix test for multiple archive usages.
baterflyrity Sep 30, 2023
1612cb4
Fix issue 534
baterflyrity Sep 30, 2023
2d1a225
Update tests/test_basic.py
baterflyrity Oct 1, 2023
6be10df
Update tests/test_basic.py
miurahr Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py7zr/py7zr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ def __init__(self, files, src_start: int, header, mp=False) -> None:
self.src_start = src_start
self.header = header
self.current_file_index = len(self.files)
self.last_file_index = len(self.files)
self.last_file_index = len(self.files) - 1
if mp:
self.concurrent: Union[Type[Thread], Type[Process]] = Process
else:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,3 +273,9 @@ def test_py7zr_list_values():
assert file_list[1].crc32 == 0xB36AAEDB
assert file_list[2].crc32 == 0xDCBF8D07
assert file_list[3].crc32 == 0x80FC72BE

@pytest.mark.basic
baterflyrity marked this conversation as resolved.
Show resolved Hide resolved
def test_multiple_uses():
with py7zr.SevenZipFile(os.path.join(testdata_path, "test_multiple.7z"), "w") as archive:
archive.writestr('1', '1.txt')
miurahr marked this conversation as resolved.
Show resolved Hide resolved
archive.test()
Loading