Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix#534] IndexError / Worker initialization sets wrong last_file_index #535

Merged
merged 6 commits into from
Nov 2, 2023
Merged

[Fix#534] IndexError / Worker initialization sets wrong last_file_index #535

merged 6 commits into from
Nov 2, 2023

Conversation

baterflyrity
Copy link
Contributor

@miurahr
Copy link
Owner

miurahr commented Sep 30, 2023 •
edited
Loading

tox -e check failed with code style error.

  tests/test_basic.py:277:1: BLK100 Black would make changes.
  tests/test_basic.py:277:1: E302 expected 2 blank lines, found 1

I would like to recommend you to run black to format the code.

@miurahr miurahr added the bug Something isn't working label Sep 30, 2023
@baterflyrity @miurahr
Update tests/test_basic.py
2d1a225 
Black style fix.

Co-authored-by: Hiroshi Miura <[email protected]>
@baterflyrity
Copy link
Contributor Author

baterflyrity commented Oct 1, 2023 •
edited
Loading

Hope, this time it will pass.

@miurahr
Copy link
Owner

miurahr commented Nov 2, 2023

You can run tox -e check and see errors on your desktop

tox: check
  check: commands[0]> flake8 py7zr tests
  tests/test_basic.py:281:26: BLK100 Black would make changes.

@miurahr miurahr changed the title Fix #534 [Fix#534] IndexError / Worker initialization sets wrong last_file_index Nov 2, 2023
miurahr
miurahr reviewed Nov 2, 2023
View reviewed changes
tests/test_basic.py Outdated Show resolved Hide resolved
@miurahr miurahr merged commit 86cf23a into miurahr:master Nov 2, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miurahr miurahr miurahr left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baterflyrity @miurahr