Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes for MSBuildEditor LSP #97

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Misc fixes for MSBuildEditor LSP #97

wants to merge 19 commits into from

Commits on Sep 3, 2024

  1. Fix some nullability issues

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    66e1c97 View commit details
    Browse the repository at this point in the history

  2. Clean up diagnostic message formatting

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1eb8342 View commit details
    Browse the repository at this point in the history

  3. Improve some doc comments

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    38d91b1 View commit details
    Browse the repository at this point in the history

  4. Make XML triggering code public for MSBuildEditor LSP

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fbfee69 View commit details
    Browse the repository at this point in the history

  5. Support line/col in TextWithMarkers

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0f9b899 View commit details
    Browse the repository at this point in the history

  6. Fix nullability warning in BackgroundProcessor

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0f56c9f View commit details
    Browse the repository at this point in the history

  7. Sort Directory.Packages.props

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dff45c7 View commit details
    Browse the repository at this point in the history

  8. Remove redundant plural TargetFrameworks

    @mhutch
    mhutch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9fa78cb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Fix TextWithMarkers ignoring custom marker

    @mhutch
    mhutch committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    11ca5cb View commit details
    Browse the repository at this point in the history

  2. Ignore expected errors in editor composition

    @mhutch
    mhutch committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b4137f8 View commit details
    Browse the repository at this point in the history

  3. Fix nasty bug in spine recovery 

    The tests were accidentally "cheating" by recovering from
the position before the actual target and catching up, so
did not trigger this bug.

Add a couple more granualar recovery tests to make it easier
to debug these kinds of issues.
    @mhutch
    mhutch committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c7b108f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix line/col in TextWithMarkers

    @mhutch
    mhutch committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e5c608d View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Add Roslyn-inspired model for settings/options 

    Nothing uses it yet but it'll be used by MonoDevelop.MSBuild,
and at some point used by the XML formatter and XML editor.
    @mhutch
    mhutch committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    95aafd2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Some fixes to the options API

    @mhutch
    mhutch committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c73558a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Always build net48 assemblies but only run net48 tests on Windows 

    This means we can build the whole solution on Mac/Linux without
needing a solution filter
    @mhutch
    mhutch committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c03f37e View commit details
    Browse the repository at this point in the history

  2. Cancel background parser on dispose

    @mhutch
    mhutch committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1f8e22d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Add trace code to help debug nondeterministic test failures on CI

    @mhutch
    mhutch committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c3a7208 View commit details
    Browse the repository at this point in the history

  2. Add fix/workaround for race in MSBuild completion tests on CI

    @mhutch
    mhutch committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a4e97ec View commit details
    Browse the repository at this point in the history

  3. Yield UI thread between editor commands in tests

    @mhutch
    mhutch committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    93927f4 View commit details
    Browse the repository at this point in the history