Misc fixes for MSBuildEditor LSP #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were accidentally "cheating" by recovering from the position before the actual target and catching up, so did not trigger this bug. Add a couple more granualar recovery tests to make it easier to debug these kinds of issues.
Nothing uses it yet but it'll be used by MonoDevelop.MSBuild, and at some point used by the XML formatter and XML editor.
This means we can build the whole solution on Mac/Linux without needing a solution filter
mhutch
force-pushed
the
misc-lsp-fixes
branch
3 times, most recently
from
6d01c4d
to
3931eeb
Compare
mhutch
force-pushed
the
misc-lsp-fixes
branch
from
3931eeb
to
a4e97ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc fixes needed for MSBuildEditor LSP