Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdk element improvements #225

Merged
merged 6 commits into from
May 9, 2024
Merged

Sdk element improvements #225

merged 6 commits into from
May 9, 2024

Commits on May 3, 2024

  1. Support MinimumVersion attribute on Sdk element 

    While this isn't documented, it is present in the MSBuild implementation
    @mhutch
    mhutch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bf51407 View commit details
    Browse the repository at this point in the history

  2. Add tests for Import version attribute validation

    @mhutch
    mhutch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fe1b5c8 View commit details
    Browse the repository at this point in the history

  3. Add diagnostic for redundant MinimumVersion

    @mhutch
    mhutch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7c29bd6 View commit details
    Browse the repository at this point in the history

  4. Add diagnostic for misleading Sdk element ordering

    @mhutch
    mhutch committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7f50c21 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Support Sdk elements and improve SDK imports 

    * Sdk elements now work and have various validations
* Import elements now support Version and MinimumVersion and
  share the SDK resolution validations with the Sdk element
* SDK names and versions in Sdk and Import elements can now use
  expressions with properties
* Added tests for the new features and validations
    @mhutch
    mhutch committed May 9, 2024
    Configuration menu
    Copy the full SHA
    571d861 View commit details
    Browse the repository at this point in the history

  2. Refactoring and nullability 

    ResolveImport really belongs on MSBuildImportResolver
    @mhutch
    mhutch committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2884f6c View commit details
    Browse the repository at this point in the history