Sdk element improvements #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this isn't documented, it is present in the MSBuild implementation
mhutch
force-pushed
the
sdk-element-improvements
branch
from
e71255c
to
7f50c21
Compare
* Sdk elements now work and have various validations * Import elements now support Version and MinimumVersion and share the SDK resolution validations with the Sdk element * SDK names and versions in Sdk and Import elements can now use expressions with properties * Added tests for the new features and validations
mhutch
force-pushed
the
sdk-element-improvements
branch
from
6712db7
to
571d861
Compare
ResolveImport really belongs on MSBuildImportResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.