Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fetched Properties from channel and message models #825

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

72A12F4E
Copy link
Contributor

@72A12F4E 72A12F4E commented Jul 31, 2024

cleaned up from #824 which included merge commits & app icon updates

@ChrDel-2 and @garthvh are the original authors of the changes

Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I will deploy a test flight build

@garthvh
Copy link
Member

garthvh commented Aug 1, 2024

@72A12F4E The Fetched properties in core data were essentially the same as the predicates being used now, I just deleted them as they were no longer being used (and crash if you try and use them in iOS 18)

Copy link

@ChrDel ChrDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you for opening a PR for this!
🙏

@72A12F4E
Copy link
Contributor Author

72A12F4E commented Aug 1, 2024

We need to do a data purge or a migration to combine the timestamps as discussed in Discord, then this should work as expected. It might be necessary to explicitly add sorting as well

@garthvh
Copy link
Member

garthvh commented Aug 1, 2024

We need to do a data purge or a migration to combine the timestamps as discussed in Discord, then this should work as expected. It might be necessary to explicitly add sorting as well

I just removed it, messageTimestamp was always loaded in parallel

@garthvh garthvh merged commit f765c5c into main Aug 1, 2024
2 checks passed
@garthvh garthvh deleted the fix-core-data-ios-18 branch August 1, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants