-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Fetched Properties from channel and message models #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I will deploy a test flight build
@72A12F4E The Fetched properties in core data were essentially the same as the predicates being used now, I just deleted them as they were no longer being used (and crash if you try and use them in iOS 18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you for opening a PR for this!
🙏
We need to do a data purge or a migration to combine the timestamps as discussed in Discord, then this should work as expected. It might be necessary to explicitly add sorting as well |
I just removed it, messageTimestamp was always loaded in parallel |
cleaned up from #824 which included merge commits & app icon updates
@ChrDel-2 and @garthvh are the original authors of the changes