Remove Fetched Properties and Replace with FetchRequests #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garthvh
changed the title
1 task
|
Can you expand on what changed in the data model? Hard to see from the XML diffs |
|
I've opened a PR here with a cleaner commit history: #825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion from Fetched Properties to just FetchRequests, seems to be performing better than my similar attempt earlier, @72A12F4E this probably makes your refactor easier as well.
None of this seems to be iOS 18 dependent, but does fix what is currently broken in iOS 18 as well