Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed breaking typo: rename MatchesPostion into MatchesPosition #518

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fixed breaking typo: rename MatchesPostion into MatchesPosition #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39e3fb3
Fixed typo in property name matchesPostion
isaiahthedev Jan 16, 2024
5fdb150
corrected spelling on the rest of MatchesPosition instances
isaiahthedev Jan 17, 2024
4d25833
Merge branch 'main' into fixed-typo-in-property-name
isaiahthedev Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Meilisearch/ISearchable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public interface ISearchable<T>
/// Contains the location of each occurrence of queried terms across all fields.
/// </summary>
[JsonPropertyName("_matchesPosition")]
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPostion { get; }
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPosition { get; }

/// <summary>
/// Returns the numeric min and max values per facet of the hits returned by the search query.
Expand Down
8 changes: 4 additions & 4 deletions src/Meilisearch/PaginatedSearchResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class PaginatedSearchResult<T> : ISearchable<T>
/// <param name="facetDistribution"></param>
/// <param name="processingTimeMs"></param>
/// <param name="query"></param>
/// <param name="matchesPostion"></param>
/// <param name="matchesPosition"></param>
/// <param name="facetStats"></param>
/// <param name="indexUid"></param>
public PaginatedSearchResult(
Expand All @@ -32,7 +32,7 @@ public PaginatedSearchResult(
IReadOnlyDictionary<string, IReadOnlyDictionary<string, int>> facetDistribution,
int processingTimeMs,
string query,
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> matchesPostion,
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> matchesPosition,
IReadOnlyDictionary<string, FacetStat> facetStats,
string indexUid
)
Expand All @@ -45,7 +45,7 @@ string indexUid
FacetDistribution = facetDistribution;
ProcessingTimeMs = processingTimeMs;
Query = query;
MatchesPostion = matchesPostion;
MatchesPosition = matchesPosition;
FacetStats = facetStats;
IndexUid = indexUid;
}
Expand Down Expand Up @@ -92,7 +92,7 @@ string indexUid

/// <inheritdoc/>
[JsonPropertyName("_matchesPosition")]
public IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPostion { get; }
public IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPosition { get; }

/// <inheritdoc/>
[JsonPropertyName("facetStats")]
Expand Down
8 changes: 4 additions & 4 deletions src/Meilisearch/SearchResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ public class SearchResult<T> : ISearchable<T>
/// <param name="facetDistribution"></param>
/// <param name="processingTimeMs"></param>
/// <param name="query"></param>
/// <param name="matchesPostion"></param>
/// <param name="matchesPosition"></param>
/// <param name="facetStats"></param>
/// <param name="indexUid"></param>
public SearchResult(IReadOnlyCollection<T> hits, int offset, int limit, int estimatedTotalHits,
IReadOnlyDictionary<string, IReadOnlyDictionary<string, int>> facetDistribution,
int processingTimeMs, string query,
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> matchesPostion,
IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> matchesPosition,
IReadOnlyDictionary<string, FacetStat> facetStats,
string indexUid)
{
Expand All @@ -36,7 +36,7 @@ public SearchResult(IReadOnlyCollection<T> hits, int offset, int limit, int esti
FacetDistribution = facetDistribution;
ProcessingTimeMs = processingTimeMs;
Query = query;
MatchesPostion = matchesPostion;
MatchesPosition = matchesPosition;
FacetStats = facetStats;
IndexUid = indexUid;
}
Expand Down Expand Up @@ -77,7 +77,7 @@ public SearchResult(IReadOnlyCollection<T> hits, int offset, int limit, int esti

/// <inheritdoc/>
[JsonPropertyName("_matchesPosition")]
public IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPostion { get; }
public IReadOnlyDictionary<string, IReadOnlyCollection<MatchPosition>> MatchesPosition { get; }

/// <inheritdoc/>
[JsonPropertyName("facetStats")]
Expand Down