Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breaking typo: rename MatchesPostion into MatchesPosition #518

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fixed breaking typo: rename MatchesPostion into MatchesPosition #518

merged 3 commits into from
Jan 31, 2024

Conversation

isaiahthedev
Copy link
Contributor

Pull Request

Fixes #516

  • Fixed typo in property name matchesPostion

@curquiza
Copy link
Member

@isaiahthedev thank your for the PR

@isaiahthedev
Copy link
Contributor Author

@curquiza Hi, I updated the PR with the recommended changes. I'm away from my personal computer so I wasn't able to to test the usage unfortunately

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Jan 31, 2024
@curquiza curquiza changed the title Fixed typo in property name matchesPostion Fixed breaking typo: rename MatchesPostion into MatchesPosition Jan 31, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jan 31, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 7571b42 into meilisearch:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in property name MatchesPostion
2 participants