Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swatch-renderer-ext): Make prices be updated also in list mode view #51

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
+3 −0
Open

fix(swatch-renderer-ext): Make prices be updated also in list mode view #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Magento_Swatches/web/js/swatch-renderer-ext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ define(['jquery', 'underscore', 'mage/translate'], function($, _, $t) {
return;
}

this.options.selectorProduct =
'.product-info-main, .cs-product-tile';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the fix a bit up to widget options. It will be more flexible to place proper value for selectorProduct there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that won't work, because selectorProduct is an already defined option? this line is here to replace the existing option value.

At least somehow I think it didn't work in our case if I just added it next to other options

this._super();

var isPdp = this.element.parents(this.options.selectorPdp)
Expand Down