fix(swatch-renderer-ext): Make prices be updated also in list mode view #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiewierska
reviewed
Feb 23, 2021
| @@ -32,6 +32,9 @@ define(['jquery', 'underscore', 'mage/translate'], function($, _, $t) { | |||
| return; | |||
| } | |||
|
|
|||
| this.options.selectorProduct = | |||
| '.product-info-main, .cs-product-tile'; | |||
|
|
|||
There was a problem hiding this comment.
Please move the fix a bit up to widget options. It will be more flexible to place proper value for selectorProduct there.
There was a problem hiding this comment.
I'm afraid that won't work, because selectorProduct is an already defined option? this line is here to replace the existing option value.
At least somehow I think it didn't work in our case if I just added it next to other options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two
.price-boxdivs per each.cs-product-tile(1 for grid view, 1 for list view), and only one of them (the grid view one) is contained in the defaultthis.options.selectorProductwhich is.product-info-main.Because of that, currently if user selects a swatch in the product listing in list view mode, the price is not updated. (It is updated only in grid view mode).
This PR fixes it.