Refactor the help/usage message for canplayer #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Please add |
Limit the error return value only to unknown options. If the utility is invoked with the help option '-h', display the usage message and exit successfully. Co-authored-by: Filip Valgimigli <[email protected]> Signed-off-by: Filip Valgimigli <[email protected]>
Oh, I really missed on this. I amended the previous commit so it's all well packed together. Hope it looks good know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
as a side effect of PR #521 development, we noticed that the
canplayerutility returns with an error value, even when asked for the help message explicitly. We thought it might be nicer to limit the above behavior only to unknown options.We also changed the option from a question mark
-?into an-h, which is more common among CLI tools.Hope you'll find these nuances sound and do not hesitate to request changes.
Have a great day again!