Refactor the help/usage message for canplayer

Limit the error return value only to unknown options. If the utility is invoked with the help option '-h', display the usage message and exit successfully. Co-authored-by: Filip Valgimigli <[email protected]> Signed-off-by: Filip Valgimigli <[email protected]>
linux-can · May 14, 2024 · e274001 · e274001
1 parent 185c14f
commit e274001
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/canplayer.c b/canplayer.c
@@ -279,7 +279,7 @@ int main(int argc, char **argv)
 	char *fret;
 	unsigned long long sec, usec;
 
-	while ((opt = getopt(argc, argv, "I:l:tin:g:s:xv?")) != -1) {
+	while ((opt = getopt(argc, argv, "I:l:tin:g:s:xvh")) != -1) {
 		switch (opt) {
 		case 'I':
 			infile = fopen(optarg, "r");
@@ -334,10 +334,14 @@ int main(int argc, char **argv)
 			verbose++;
 			break;
 
-		case '?':
+		case 'h':
+			print_usage(basename(argv[0]));
+			exit(EXIT_SUCCESS);
+			break;
+
 		default:
 			print_usage(basename(argv[0]));
-			return 1;
+			exit(EXIT_FAILURE);
 			break;
 		}
 	}