-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove macos-12; add macos-15-large #63
base: master
Are you sure you want to change the base?
Conversation
https://github.com/lima-vm/socket_vmnet/actions/runs/11668029741/job/32487531768?pr=63
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
.github/workflows/test.yml
Outdated
@@ -30,6 +30,8 @@ jobs: | |||
uname -a | |||
sw_vers | |||
ifconfig | |||
- name: Disable firewall | |||
run: sudo /usr/libexec/ApplicationFirewall/socketfilterfw --setglobalstate off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still failing 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No route to host
doesn't sound like a firewall problem, but a routing table issue.
Maybe print out the routing table as part of the action?
Also maybe run on macos-13 instead of macos-15? And if that works, compare routing tables between the runners.
58aaf63
to
9dec178
Compare
The macos-12 CI is currently down on purpose and will be completely removed by Dec 3, 2024. (actions/runner-images issue 10721) Signed-off-by: Akihiro Suda <[email protected]>
https://github.com/lima-vm/socket_vmnet/actions/runs/11670466432/job/32494724116?pr=63
The routing table seems just same as macos-13. "No route to host" doesn't seem to occur with The CI is passing for macos-14-large as well as macos-13-large, so something should have changed in macos-15-large. |
I would split the changes to:
|
The macos-12 CI is currently down on purpose and will be completely removed by Dec 3, 2024. (actions/runner-images#10721)