Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove macos-12; add macos-15-large #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AkihiroSuda
Copy link
Member

The macos-12 CI is currently down on purpose and will be completely removed by Dec 3, 2024. (actions/runner-images#10721)

@AkihiroSuda AkihiroSuda added this to the v1.1.8 milestone Nov 4, 2024
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 4, 2024

https://github.com/lima-vm/socket_vmnet/actions/runs/11668029741/job/32487531768?pr=63

▶ Run limactl shell vm1 ip -4 -json addr show dev lima0 | jq -r .[0].addr_info[0].local | tee /tmp/vm1_iP
192.168.105.3
▶ Run iperf3 -c "$(cat /tmp/vm1_ip)"
  
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

jandubois
jandubois previously approved these changes Nov 4, 2024
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@@ -30,6 +30,8 @@ jobs:
uname -a
sw_vers
ifconfig
- name: Disable firewall
run: sudo /usr/libexec/ApplicationFirewall/socketfilterfw --setglobalstate off
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing 😞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No route to host doesn't sound like a firewall problem, but a routing table issue.

Maybe print out the routing table as part of the action?

Also maybe run on macos-13 instead of macos-15? And if that works, compare routing tables between the runners.

The macos-12 CI is currently down on purpose and will be completely removed by
Dec 3, 2024. (actions/runner-images issue 10721)

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 4, 2024

https://github.com/lima-vm/socket_vmnet/actions/runs/11670466432/job/32494724116?pr=63

+ netstat -rn
Routing tables

Internet:
Destination        Gateway            Flags               Netif Expire
default            192.168.64.1       UGScg                 en0       
default            link#11            UCSIg           bridge100      !
127                127.0.0.1          UCS                   lo0       
127.0.0.1          127.0.0.1          UH                    lo0       
169.254            link#5             UCS                   en0      !
192.168.64         link#5             UCS                   en0      !
192.168.64.1/32    link#5             UCS                   en0      !
192.168.64.1       16:9d:99:c7:98:64  UHLWIir               en0   1144
192.168.64.30/32   link#5             UCS                   en0      !
192.168.105        link#11            UC              bridge100      !
192.168.105.2      link#11            UHLWIi          bridge100      !
192.168.105.3      52.55.55.e7.4b.ea  UHLWIi          bridge100   1186
[...]

++ cat /tmp/vm1_ip
+ ping -c 3 192.168.105.3
PING 192.168.105.3 (192.168.105.3): 56 data bytes
64 bytes from 192.168.105.3: icmp_seq=0 ttl=64 time=1.498 ms
64 bytes from 192.168.105.3: icmp_seq=1 ttl=64 time=1.661 ms
64 bytes from 192.168.105.3: icmp_seq=2 ttl=64 time=3.294 ms

--- 192.168.105.3 ping statistics ---
3 packets transmitted, 3 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 1.498/2.151/3.294/0.811 ms
++ cat /tmp/vm1_ip
+ iperf3 -c 192.168.105.3
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

The routing table seems just same as macos-13.

"No route to host" doesn't seem to occur with ping 🤔

The CI is passing for macos-14-large as well as macos-13-large, so something should have changed in macos-15-large.

@nirs
Copy link
Contributor

nirs commented Nov 7, 2024

I would split the changes to:

  • remove macos-12 to ubreak the build
  • add macos-14 since it works now
  • add macos-15 later, probably need more work

@AkihiroSuda AkihiroSuda removed this from the v1.1.8 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants