Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove macos-12 #2840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: remove macos-12 #2840

wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Nov 4, 2024
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Nov 4, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 4, 2024
Merged
@AkihiroSuda
CI: remove macos-12
f170785 
The macos-12 CI is currently down on purpose and will be completely removed by
Dec 3, 2024.

See actions/runner-images issue 10721.

Close issue 2695

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

vmnet test is failing 😞

+ limactl shell default iperf3 -s -1 -D
time="2024-11-04T16:04:01Z" level=warning msg="treating lima version \"4874db5\" from \"/Users/runner/.lima/default/lima-version\" as very latest release"
+ iperf3 -c 192.168.105.4
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

https://github.com/lima-vm/lima/actions/runs/11667264725/job/32485783777?pr=2840

jandubois
jandubois previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois dismissed their stale review November 4, 2024 16:47

Didn't see vmnet failing; might just need firewall rule update

@AkihiroSuda
Copy link
Member Author

might just need firewall rule update

Not sure how to update 😥
lima-vm/socket_vmnet#63 (comment)

@AkihiroSuda AkihiroSuda removed this from the v1.0 milestone Nov 5, 2024
@AkihiroSuda AkihiroSuda added help wanted Extra attention is needed component/network/vmnet labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear approved these changes

@jandubois jandubois jandubois left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/test Tests and CI component/network/vmnet help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macos-12 runner in GitHub Actions is deprecated
3 participants
@AkihiroSuda @jandubois @alexandear