add more stackrox/acs metrics #103
Conversation
|
/cc @jtaleric |
davdhacs
force-pushed
the
rox-26061-more-stackrox-metrics
branch
from
188a9a9
to
ef0abda
Compare
| @@ -224,6 +224,788 @@ | |||
| metricName: max-memory-stackrox | |||
| instant: true | |||
|
|
|||
| # ACS - Central | |||
There was a problem hiding this comment.
I don't think we should add ACS metrics in this file, metrics here are for standard OCP deployments, how are you using it? There's not any ACS related workload in this repository
There was a problem hiding this comment.
If you're using this metrics file from an external repo I recommend you to create a new metrics file with all the acs/stackrox stuff rather than modifying this one
There was a problem hiding this comment.
If I add a new metrics file, how do I use it? (ideally by changing arguments for the existing openshift-ci steps like for cluster-density)
Here's what I'm trying: openshift/release#56471
The alternatives I found add complexity that I would like to avoid (duplicating steps or modifying the e2e-benchmarking run.sh), or require changes to kube-burner-ocp code (like #102).
Copied from https://github.com/stackrox/stackrox/blob/master/tests/performance/scale/tests/kube-burner/cluster-density/metrics.yml