Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Set custom metric-profiles from flag #110

Closed
rsevilla87 opened this issue Sep 25, 2024 · 1 comment · Fixed by #111
Closed

[RFE] Set custom metric-profiles from flag #110

rsevilla87 opened this issue Sep 25, 2024 · 1 comment · Fixed by #111
Assignees
Labels
enhancement New feature or request

Comments

@rsevilla87
Copy link
Member

rsevilla87 commented Sep 25, 2024

Is your feature request related to a problem? Please describe.

With the current implementation, each workload has predefined a metric-profile (metrics.yml, metrics-aggregated.yml, metrics-egress.yml, etc), it would be useful to allow the user to use an external metric-profile

Describe the solution you'd like

A metric-profile list can be passed as a flagThat metric profile can be passed from a flag, i.e:

 ./bin/amd64/kube-burner-ocp cluster-density-v2 --iterations=10 --metrics-profile=custom-metrics.yml,more-metrics.yml

If this flag is not set, kube-burner will follow the previous behavior, of using the pre-defined embedded metrics-profile of the workload in question.

Describe alternatives you've considered

As part of this effort, we can end up deprecating the flag --profile-type, that would mean that the files specified by --metrics-profile can also be embedded in the kube-burner-ocp binary

Additional context

Having this PR can help to fix issues like the one that is trying to fix with #103, which basically is extending the default metrics profile with not relevant prometheus expresions for standards clusters due to the impossibility of using a different metrics-profile rather than the default one.

@rsevilla87 rsevilla87 added the enhancement New feature or request label Sep 25, 2024
@rsevilla87 rsevilla87 self-assigned this Sep 25, 2024
@vishnuchalla
Copy link
Contributor

@rsevilla87 If we simply deprecate --profile-type flag, it might impact our CI jobs. JFYI.
Also there is a bug: kube-burner/kube-burner#683 which is relevant to this. Hoping that to be fixed as well with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants