-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Fine-Tuned Zim Search #1189
Open
ShaopengLin
wants to merge
23
commits into
main
Choose a base branch
from
Issue#413-search-UI-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7b7c949
Introduce suggestiolistmodel.{h, cpp}
ShaopengLin 1f1743b
Move SearchBarLineEdit urlList to SuggestionListModel
ShaopengLin 8611a1c
Enter Library::getZimIcon()
ShaopengLin 6cbc9e8
Add Suggestion Icon Decoration Role
ShaopengLin c029da2
Refactor SuggestionListWorker
ShaopengLin d5de7c6
Introduce SuggestionListModel::lastIndex
ShaopengLin 0aac03f
Introduce Endless Suggestions
ShaopengLin 84e29ec
Endless Suggestion Key press compatible
ShaopengLin 2aca115
Endless Suggestion Page_Down Compatible
ShaopengLin 1894d41
Correctly handle Endless w/Fulltext
ShaopengLin d0a1680
Fetch Only When More Suggesion Exist
ShaopengLin 76bae0d
Make First Row Visible on Suggestion Popup
ShaopengLin a7d7304
Introduce Kiwix Search Header
ShaopengLin d713173
Replace m_completer.popup() with m_suggestionView
ShaopengLin b3d9424
Enter KiwixApp::getSearchBar()
ShaopengLin ff7117b
BugFix openCompletion Connected Multiple Times
ShaopengLin ce36366
Make SearchBar Margin Consistent
ShaopengLin b9f4f94
Align Search Suggestion with Line Edit
ShaopengLin 02e042a
Fix Suggestion Flickering when Typing
ShaopengLin dac8d04
Proper Size for Suggestion View
ShaopengLin fcebdd0
Proper Suggestion Icon&Text Spacing
ShaopengLin 64b30c3
Proper Hover Style to Suggestion Items
ShaopengLin b19ea81
Proper Elide for Suggestion List Text
ShaopengLin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many magic numbers.