Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Fine-Tuned Zim Search #1189

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Implement Fine-Tuned Zim Search #1189

wants to merge 23 commits into from

Commits on Sep 28, 2024

  1. Introduce suggestiolistmodel.{h, cpp} 

    Allow future customizing of suggestions.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7b7c949 View commit details
    Browse the repository at this point in the history

  2. Move SearchBarLineEdit urlList to SuggestionListModel 

    More cohesive design to utilize new model's index data.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1f1743b View commit details
    Browse the repository at this point in the history

  3. Enter Library::getZimIcon() 

    Refactor to simplify zim icon retrieval
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8611a1c View commit details
    Browse the repository at this point in the history

  4. Add Suggestion Icon Decoration Role

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    6cbc9e8 View commit details
    Browse the repository at this point in the history

  5. Refactor SuggestionListWorker 

    Add offset and fetch size, prepare for endless.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c029da2 View commit details
    Browse the repository at this point in the history

  6. Introduce SuggestionListModel::lastIndex 

    Shorter last index retrieval
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d5de7c6 View commit details
    Browse the repository at this point in the history

  7. Introduce Endless Suggestions 

    Trigger on scroll.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0aac03f View commit details
    Browse the repository at this point in the history

  8. Endless Suggestion Key press compatible 

    Down Key press correctly fetches.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    84e29ec View commit details
    Browse the repository at this point in the history

  9. Endless Suggestion Page_Down Compatible 

    Can use page down button to fetch
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2aca115 View commit details
    Browse the repository at this point in the history

  10. Correctly handle Endless w/Fulltext 

    Fetch offset and model removal requires this.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1894d41 View commit details
    Browse the repository at this point in the history

  11. Fetch Only When More Suggesion Exist

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d0a1680 View commit details
    Browse the repository at this point in the history

  12. Make First Row Visible on Suggestion Popup 

    Before, view scroll to row based on prefix match
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    76bae0d View commit details
    Browse the repository at this point in the history

  13. Introduce Kiwix Search Header

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a7d7304 View commit details
    Browse the repository at this point in the history

  14. Replace m_completer.popup() with m_suggestionView

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d713173 View commit details
    Browse the repository at this point in the history

  15. Enter KiwixApp::getSearchBar() 

    Refactor to reduce getter chaining length
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b3d9424 View commit details
    Browse the repository at this point in the history

  16. BugFix openCompletion Connected Multiple Times 

    Focus event can happen more than once.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ff7117b View commit details
    Browse the repository at this point in the history

  17. Make SearchBar Margin Consistent

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ce36366 View commit details
    Browse the repository at this point in the history

  18. Align Search Suggestion with Line Edit

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b9f4f94 View commit details
    Browse the repository at this point in the history

  19. Fix Suggestion Flickering when Typing 

    setCompleter call setCompletionPrefix on typing which flicker
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    02e042a View commit details
    Browse the repository at this point in the history

  20. Proper Size for Suggestion View 

    Header&Row height as 34px. 5 extra on top&bottom of view.
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    dac8d04 View commit details
    Browse the repository at this point in the history

  21. Proper Suggestion Icon&Text Spacing 

    Aligns with search title and search text
    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    fcebdd0 View commit details
    Browse the repository at this point in the history

  22. Proper Hover Style to Suggestion Items

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    64b30c3 View commit details
    Browse the repository at this point in the history

  23. Proper Elide for Suggestion List Text

    @ShaopengLin
    ShaopengLin committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b19ea81 View commit details
    Browse the repository at this point in the history