Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4131 #4133

Merged
merged 7 commits into from
Jan 8, 2021
Merged

Issue 4131 #4133

merged 7 commits into from
Jan 8, 2021

Commits on Jan 5, 2021

  1. Correct naming: rulesetManagementInterface -> rulesetManagement

    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d35a724 View commit details
    Browse the repository at this point in the history

  2. Correct naming: rulesetManagementInterface -> rulesetManagement

    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    4c4536a View commit details
    Browse the repository at this point in the history

  3. Simplify creation of RulesetNotFoundException

    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3888813 View commit details
    Browse the repository at this point in the history

  4. Make RulesetNotFoundException a FileNotFoundException 

    This simplifies exception handling a lot
    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    9e71e93 View commit details
    Browse the repository at this point in the history

  5. Simplify code, remove unnecessary delegate function

    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    fcab08d View commit details
    Browse the repository at this point in the history

  6. Remove strangely extractey sub-method 

    The method did unrelated initializations and more than its name
suggested. Tracking the time is not necessary here either because the
ruleset service already does.
    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    cb20c78 View commit details
    Browse the repository at this point in the history

  7. Remove unlucky catching of exception which caused follow-up error

    Matthias Ronge committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3c38870 View commit details
    Browse the repository at this point in the history