Issue 4131 #4133
Merged
Issue 4131 #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 5, 2021 14:11
This simplifies exception handling a lot
The method did unrelated initializations and more than its name suggested. Tracking the time is not necessary here either because the ruleset service already does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of cleanup going on here. The real problem is fixed in the last commit: Because the exception is no longer caught at this point, the method crashes and the exception is caught further up (which was already implemented) and displayed as an error. The code no longer tries to continue working and to access the object that could not be initialized. So the UI doesn't crash anymore.
Fixes #4131