Interactive tree layout and relative constraints for layered #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddykasp
reviewed
Nov 10, 2022
packages/klighd-interactive/src/klighd-interactive-mouselistener.ts
Outdated
Show resolved
Hide resolved
packages/klighd-interactive/src/klighd-interactive-mouselistener.ts
Outdated
Show resolved
Hide resolved
packages/klighd-interactive/src/klighd-interactive-mouselistener.ts
Outdated
Show resolved
Hide resolved
soerendomroes
requested review from
NiklasRentzCAU
and removed request for
NiklasRentzCAU
NiklasRentzCAU
approved these changes
Mar 13, 2024
| @@ -178,6 +178,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@kieler/klighd-core": "^0.4.2", | |||
| "@kieler/klighd-interactive": "^0.4.2", | |||
There was a problem hiding this comment.
this is a transient dependency, so we should not be required to repeat this dependency here
|
What are in general the new additions of this PR except for the interactive mr tree? |
|
@NiklasRentzCAU This PR supersedes #121, which added relative constraints as well as generalized the interactive process. |
soerendomroes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on interactive rework #121